GithubHelp home page GithubHelp logo

rustc-auto-publish's People

Contributors

alexcrichton avatar andjo403 avatar calebcartwright avatar lambda-fairy avatar mark-i-m avatar msizanoen avatar topecongiro avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

rustc-auto-publish's Issues

Failure publishing some crates due to missing dep versions

There's been some intermittent publish failures over the last few weeks that's resulted in a couple missing crate versions, most recently with rustc_parse. I'm hoping the issue is just timing with dependency relationships between these crates, and the new dependent version not quite hitting the index before the consuming crate versions are published.

publishing rustc_fs_util 663.0.0
    Updating crates.io index
   Packaging rustc-ap-rustc_fs_util v663.0.0 (/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/foo.bixavKjKmtxA/rust-ccac43b86b559e01fa71179af1a838ab94559c75/src/librustc_fs_util)
   Uploading rustc-ap-rustc_fs_util v663.0.0 (/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/foo.bixavKjKmtxA/rust-ccac43b86b559e01fa71179af1a838ab94559c75/src/librustc_fs_util)
publishing rustc_session 663.0.0
    Updating crates.io index
   Packaging rustc-ap-rustc_session v663.0.0 (/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/foo.bixavKjKmtxA/rust-ccac43b86b559e01fa71179af1a838ab94559c75/src/librustc_session)
   Uploading rustc-ap-rustc_session v663.0.0 (/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/foo.bixavKjKmtxA/rust-ccac43b86b559e01fa71179af1a838ab94559c75/src/librustc_session)
publishing rustc_parse 663.0.0
    Updating crates.io index
error: failed to select a version for the requirement `rustc-ap-rustc_session = "^663.0.0"`
  candidate versions found which didn't match: 662.0.0, 660.0.0, 659.0.0, ...
  location searched: crates.io index
required by package `rustc-ap-rustc_parse v663.0.0 (/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/foo.bixavKjKmtxA/rust-ccac43b86b559e01fa71179af1a838ab94559c75/src/librustc_parse)`
thread 'main' panicked at 'assertion failed: result.success()', src/main.rs:380:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
##[error]Process completed with exit code 101.

No updates in the last 2 months

I'm trying to build cargo-modules (see regexident/cargo-modules#49), and I'm seeing an error on Nightly happening in one of the dependencies of rust-ap-syntax. Crates show that all the dependencies are currently at version 656. What is the reason rust-ap-syntax is still at 645 and not updated in the last 2 months?

The name of crates have been renamed with `rustc_ap_` prefix

For example, the following snippets show the part of Cargo.toml of rustc-ap-syntax 583.0.0 and 605.0.0:

[package]
edition = "2018"
name = "rustc-ap-syntax"
version = "583.0.0"
authors = ["The Rust Project Developers"]
description = "Automatically published version of the package `syntax` in the rust-lang/rust repository from commit f7b05af814f02681d8973438df4ed5792f581841 The publishing script for this crate lives at: https://github.com/alexcrichton/rustc-auto-publish\n            "
license = "MIT / Apache-2.0"
repository = "https://github.com/rust-lang/rust"

[lib]
name = "syntax"
path = "lib.rs"
doctest = false
[dependencies.bitflags]
version = "1.0"
[package]
edition = "2018"
name = "rustc-ap-syntax"
version = "605.0.0"
authors = ["The Rust Project Developers"]
description = "Automatically published version of the package `syntax` in the rust-lang/rust repository from commit c6293e359848c8c7275330719b33ccd168df04c3 The publishing script for this crate lives at: https://github.com/alexcrichton/rustc-auto-publish\n            "
license = "MIT / Apache-2.0"
repository = "https://github.com/rust-lang/rust"

[lib]
path = "lib.rs"
doctest = false
[dependencies.bitflags]
version = "1.0"

Note that in the Cargo.toml of 605.0.0, name = "syntax" is removed from the [lib] section. Hence, the name of the crate has been renamed to rustc_ap_syntax from syntax. Is this change intentional?

Delete libsyntax editing code

We've since removed the need for these hacks I believe so we can likely strip out the code which adds the feature flags and deletes the diagnostic macro.

Compilation of rustc-ap-rustc_data_structures fails

When trying to compile rustc_data_structures fails on FreeBSD 12.0 Stable it fail with this error message

   Compiling rustc-ap-rustc_data_structures v541.0.0
error[E0658]: use of unstable library feature 'test': `bench` is a part of custom test frameworks which are unstable
    --> /usr/home/xanderio/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_data_structures-541.0.0/bit_set.rs:1269:3
     |
1269 | #[bench]
     |   ^^^^^
     |
     = note: for more information, see https://github.com/rust-lang/rust   Compiling rustc-ap-rustc_data_structures v541.0.0
error[E0658]: use of unstable library feature 'test': `bench` is a part of custom test frameworks which are unstable
    --> /usr/home/xanderio/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_data_structures-541.0.0/bit_set.rs:1269:3
     |
1269 | #[bench]
     |   ^^^^^
     |
     = note: for more information, see https://github.com/rust-lang/rust/issues/50297
     = help: add `#![feature(test)]` to the crate attributes to enable

error[E0658]: use of unstable library feature 'test': `bench` is a part of custom test frameworks which are unstable
    --> /usr/home/xanderio/.cargo/registry/src/gitfailshub.com-1ecc6299db9ec823/rustc-ap-rustc_data_structures-541.0.0/bit_set.rs:1284:3
     |
1284 | #[bench]
     |   ^^^^^
     |
     = note: for more information, see https://github.com/rust-lang/rust/issues/50297
     = help: add `#![feature(test)]` to the crate attributes to enable

error[E0658]: use of unstable library feature 'test': `bench` is a part of custom test frameworks which are unstable
    --> /usr/home/xanderio/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_data_structures-541.0.0/bit_set.rs:1302:3
     |
1302 | #[bench]
     |   ^^^^^
     |
     = note: for more information, see https://github.com/rust-lang/rust/issues/50297
     = help: add `#![feature(test)]` to the crate attributes to enable

error[E0658]: use of unstable library feature 'test': `bench` is a part of custom test frameworks which are unstable
    --> /usr/home/xanderio/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_data_structures-541.0.0/bit_set.rs:1320:3
     |
1320 | #[bench]
     |   ^^^^^
     |
     = note: for more information, see https://github.com/rust-lang/rust/issues/50297
     = help: add `#![feature(test)]` to the crate attributes to enable

error[E0658]: use of unstable library feature 'test': `bench` is a part of custom test frameworks which are unstable
    --> /usr/home/xanderio/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_data_structures-541.0.0/bit_set.rs:1335:3
     |
1335 | #[bench]
     |   ^^^^^
     |
     = note: for more information, see https://github.com/rust-lang/rust/issues/50297
     = help: add `#![feature(test)]` to the crate attributes to enable
/issues/50297
     = help: add `#![feature(test)]` to the crate attributes to enable

error[E0658]: use of unstable library feature 'test': `bench` is a part of custom test frameworks which are unstable
    --> /usr/home/xanderio/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_data_structures-541.0.0/bit_set.rs:1284:3
     |
1284 | #[bench]
     |   ^^^^^
     |
     = note: for more information, see https://github.com/rust-lang/rust/issues/50297
     = help: add `#![feature(test)]` to the crate attributes to enable

error[E0658]: use of unstable library feature 'test': `bench` is a part of custom test frameworks which are unstable
    --> /usr/home/xanderio/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_data_structures-541.0.0/bit_set.rs:1302:3
     |
1302 | #[bench]
     |   ^^^^^
     |
     = note: for more information, see https://github.com/rust-lang/rust/issues/50297
     = help: add `#![feature(test)]` to the crate attributes to enable

error[E0658]: use of unstable library feature 'test': `bench` is a part of custom test frameworks which are unstable
    --> /usr/home/xanderio/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_data_structures-541.0.0/bit_set.rs:1320:3
     |
1320 | #[bench]
     |   ^^^^^
     |
     = note: for more information, see https://github.com/rust-lang/rust/issues/50297
     = help: add `#![feature(test)]` to the crate attributes to enable

error[E0658]: use of unstable library feature 'test': `bench` is a part of custom test frameworks which are unstable
    --> /usr/home/xanderio/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_data_structures-541.0.0/bit_set.rs:1335:3
     |
1335 | #[bench]
     |   ^^^^^
     |
     = note: for more information, see https://github.com/rust-lang/rust/issues/50297
     = help: add `#![feature(test)]` to the crate attributes to enable

Could this publish less often?

Right now we have 134 versions already, and their numbers keep growing.

They already are inside the top ten of crates with most versions:

    clap (204)
    clippy (196)
    sovrin-client (159)
    serde (142)
    hyper (140)
    cargo-make (136)
    project_init (135)
    rustc-ap-serialize (134)
    rustc-ap-rustc_data_structures (133)
    rustc-ap-rustc_cratesio_shim (133)

Maybe publish them in a more coarse turnus, like once per week?

What about publishing weekly?

Hi, maybe you've missed it: I haven't gotten a reply about my inquiry on the purpose.

There are over 500 versions now of 11 autopublished crates. The libsyntax crate alone takes 142 MB of storage. This is not ok.

Rustfmt, the only user of this, still seems to update in a superweekly cycle, so a weekly release schedule until rustfmt adopts rust-analyzer would be okay. @topecongiro please say if you want it to stay on a daily schedule or whether a weekly release schedule would be okay, too.

Here is a list of the last three updates (earlier ones in my comment linked above):

panic in publish job due to libsyntax rename

The most recent publish job failed with a

thread 'main' panicked at 'failed to execute cargo: Os { code: 2, kind: NotFound, message: "No such file or directory" }', 

error, and I believe that's because libsyntax appears to have been renamed to librustc_ast.

Refs: rust-lang/rust#69592

I'll open a PR to update the script to reflect that change , though it looks like we may potentially need to add some additional crates to the publish list for rustfmt (looks like libsyntax was split into multiple crates in addition to the rename)

cc @topecongiro

Edit: looks it was just the rename of libsyntax, no additional crate splitting

Does it make sense to publish `libproc_macro`?

Currently cbindgen depends on syn for parsing rust which depends on proc-macro2 which depends on proc-macro.

This works, but it means that the binary depends on rustc libs being in LD_LIBRARY_PATH, which leads to linking errors when running the binary outside of cargo run. See rust-lang/rust#47931.

I noticed that rustfmt seems to get around this by using a published version of libsyntax. Does it make sense to have a published version of libproc_macro so we could do the same? I believe all of libproc_macros dependencies are currently published.

cc @staktrace

Some rustc-ap dependencies of rustfmt are missing on crates.io

The recent refactorings have split libsyntax and its friends into multiple crates. Currently, rustfmt is trying to catch up with those changes. However, after the refactorings, some crates seem to be unavailable on crates.io.

The following is a list of crates that need to be published as rustc-ap-* on crates.io so that rustfmt can update to the latest syntax (as far as I am aware of):

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.