alexeyvoronov96 / newsapp-with-swiftui-and-combine

Used: SwiftUI and Combine

NewsApp

Used: New Apple frameworks SwiftUI and Combine

Installation:

1. Get your News API key

2. Get your Weather API key

3. Insert your keys into Container.swift file

4. Run app

Overview tab

Sources tab

Search for articles tab

Favorites tab

Current weather tab

WebView

newsapp-with-swiftui-and-combine's Issues

Change navigation and presentation buttons on new Xcode beta demands

Make alert with errors

Get info about problem with PresentationLink on MainView screen

Change TopHeadlines view to the PageViewController

Sometimes categories get stuck on endless loading

Sometimes when you click on a category in the first tab, you get stuck on loading and top headlines don't load.

App Crash when open web view

App crashes when open any article in web view.

To Reproduce
Steps to reproduce the behavior:

1. Go to category
2. Click on any article
3. App crashes - found nil while unwrapping optional
4. See error

Expected behavior
Should open article url in safari web browser.

Smartphone:

• Device: iPhone 11
• OS: iOS 15.5
• Browser: Safari

Additional context
It is crashing at 3 places when articleUrl is forced unwrapped for SafariView, In ArticlesFromSourceView.swift, ArticlesList.swift, FavoritesView.swift files.

Update downloading images to the DataTaskPublisher

Switch from Dark Sky to OpenWeather Map

I use this app on my personal device and love it but as you might know, Dark Sky will be shutting down their API. It would be great if you could switch to using OpenWeather Map or another service.