alexis-l8 / carebnb

Hi , I'm Alexis

carebnb's Issues

Remove .DS_store

@alexis-l8

https://github.com/alexis-l8/CareBnB/blob/master/.DS_Store is not a file you are every going to want to add to github

You can globally gitignore this by adding it to a ~/.gitignore_global file

Mine looks like this:

*~
.DS_Store

Run this command to always gitignore this file:

echo "*~\n.DS_Store" > ~/.gitignore_global

Create Sign up route/page

There should be 2 main sign up options, namely:
1 - Oauth, where a user can sign up using their social media account, e.g. GitHub, Facebook, Google, etc..
2 - Signing up using our website/service, where the user will have to create an account

Setup database

We have to setup the database which will contain the tables of the homeowners and homeseeker's profiles. We also need a table which will describe the preferences of the homeowners.

Link Detailed Results page to homeowner/property

Signup form

Just a UX kind of thing, but when I tab through the form to the date field, the years start at 0001. You might want to set it to start at a more sensible year? ;)

Google Maps requires longitude/latitude

Fix css of routes to previous commit

Create slideshow of properties on google marker

Create Initial File Structure

Get userdata from Database to display on the results page

Login with Facebook not working

Create formspree page

Keep Master up-to-date with latest-working Staging Branch

Technical Spike: Content Delivery Networks for serving images

Technical Spike on Google Maps Api and Handlebars

We'll be researching how to implement the Google Maps Api using Handlebars and helper functions

Create marker for user's location

Keep Readme updated

AWS S3 - List all objects in bucket

Create Home route/page using HandleBars

Create The Questionnaire route/pages

We have to create the pages which will ask the potential homeseeker a list of criteria, which we will then use to filter and display the homeowners who will be the best probable match.

Center map on hover of homeowner profile

Add Users with preferences to the database

The database should contain 6 initial homeowners with their preferences

Add Initial Invision Prototype

Helpers

https://github.com/alexis-l8/CareBnB/blob/master/src/helpers/helper_functions.js

Useful function here :D

Homeowner option link to simple file upload

Set up Travis

Set up Handlebars views

get_data.js

Good things about this:

• I like that these are nice short self-contained functions, and that they are separated from the rest of your code. So far, your file structure seems quite logical and easy to understand.

Not so good:

• You export only this one variable, which at first glance is an empty object... const dataFromDatabase = {};
• You could export the same data without mutating that object if you declared each function independently first, and then exported them in a new object (does that make sense?)
• The queries are quite hard to read because they are long and much wider than my screen. I would recommend saving all your queries as simple strings, and then just having variable names in your functions. You could put them either at the top of this file, or in their own queries.js file.

Signup is dead end

Also just a UX thing, but after signing up I don't go anywhere :( in fact, i get redirected to a formspree page.

You should want to keep me on your site!

AWS S3 - File uploading correctly

Setup Hapi-auth-cookie

We will need to use cookies to enable session management for logged in users.

Serve Static files using hapi

AWS S3 - Ability to delete objects from bucket

post.js

Similar issues here to in #75

You use destructure the object you pass in and get quite a lot of data out of it. Then you don't do anything very complicated with that data.

For the sake of keeping it short, why not not desturcture it, and instead just write a helper function to construct the array that you pass into your DB query?
Like...

const makeArray = obj => [ obj.first_name, ...  etc ]

Postcode autocomplete

As a stretch goal, it would be great if we could implement autocomplete for the postcode input field. Perhaps we could use this: http://postcodes.io/

Insert more home owners in the database

Fix Postcode/Form validation using Joi

Users are able to enter non-existing postcodes which causes either the map not to show up, or even worse the server to crash.

Post code validation

I entered an abbreviated (therefore according to your logic) invalid postcode. This resulted in a 404.

Up to you, and maybe just my opinion, but I would probably validate this kind of input in the browser.

Set up Codecov

Set up Server

Update Readme.md to show staging branch Travis/CodeCov

Display properties and users from Amazon Cloudfront

Test Server Routes

Install all dependencies

Create get-in-touch button

Profiles from results page display in an odd layout

Look into CSS.styles and make sure all profiles display in the same way

Set up eslint

Fix redirect page - map and listings

Fix homepage description

Update Learnings.md