GithubHelp home page GithubHelp logo

aliasio / demodal Goto Github PK

View Code? Open in Web Editor NEW
245.0 245.0 22.0 118 KB

Demodal is a browser extension that automatically removes content blocking modals including paywalls, discount offers, promts to sign up or enter your email address and more.

Home Page: https://www.demodal.com

License: MIT License

JavaScript 72.15% HTML 15.53% CSS 9.66% Shell 2.65%
browser-extension modal-blocker

demodal's People

Contributors

aliasio avatar extrowerk avatar labellson avatar lcomrade avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

demodal's Issues

The Wall Street Journal

The wall street journal
paywall still there

ex:
https://www.wsj.com
https://www.wsj.com/articles/states-file-new-suits-against-google-over-location-tracking-11643037890

Great addon !

modal not blocked on celticseasalt.com

The modal on this website isn't being blocked: https://www.celticseasalt.com/
Instructions for replication: Enter the site, wait about 5 seconds, and it pops up.

Screenshot from 2023-07-29 02-31-56

I modified your code you suggested to me from my previous issue into this, but it doesn't remove it:

{
  "celticseasalt.com": {
    "body div[style*='z-index']": "removeIf 'Join'"
  }
}

By the way, is reporting unblocked modals here in the issues page the way we improve Demodal for future versions?

Thanks either way. Cookie and newsletter modals are the bane of my internet experience and your addon helps restore some sanity.

TypeError: node.dataset is undefined

I noticed this extension logs an error whenever an element containing only text is updated.
This issue appears to be Firefox only. I observed this issue in v112.

The problem comes from this section of content.js line 154-156

mutations.every((mutation) =>
  Array.from(mutation.addedNodes).every((node) => node.dataset.demodal)
)

In firefox, when a node containing just text is updated, node.dataset is null, and the attempt to read .demodal causes a type error.

I think the above code could be changed as follows to filter out text-only mutations.

mutations.every((mutation) =>
  Array.from(mutation.addedNodes).every((node) => node.dataset == null || node.dataset.demodal)
)

Here is a minimal html file which triggers the issue once per second.
npx http-server --port 8000 and navigate to http://localhost:8000/issue.html

<html>
<head>
  <script>
    document.addEventListener('DOMContentLoaded', () => {
      const content = document.getElementById("content");
      let count = 0;
      setInterval(() => {
        count++;
        content.innerText = `Some Content ${count}`;
      }, 1000);
    });
  </script>
</head>

<body>
  <div id="content">Some Content 0</div>
</body>
</html>

model overlay on coasttocoastam.com

There's a modal overlay on coasttocoastam.com that demodal doesn't handle.
It blocks page views a couple of seconds after the page loads until clicked.
Pretty annoying, the main reason I picked up your addon.

The majority of assets this page loads come from either iheart.com or adobedtm.com, if that makes any difference.

c2c

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.