missing argument instance_tags for filter instances about alibaba.alicloud

[colinleefish]

+1. A tag filter would be very helpful.

[colinleefish]

@ranger-huang Hi. I managed to come up with an easy fix.

    if names:
        for name in names:
            for inst in ecs.get_all_instances(zone_id=zone_id, instance_ids=ids, instance_name=name):
                instances.append(get_instance_info(inst))
                instance_ids.append(inst.id)
    elif instance_tags:
        for inst in ecs.get_all_instances(zone_id=zone_id, instance_ids=ids, instance_tags=instance_tags):
            instances.append(get_instance_info(inst))
            instance_ids.append(inst.id)
    else:
        for inst in ecs.get_all_instances(zone_id=zone_id, instance_ids=ids):
            instances.append(get_instance_info(inst))
            instance_ids.append(inst.id)

Further, you may change

        instance_tags=dict(type='list', aliases=['tags']),

to

        instance_tags=dict(type='dict', aliases=['tags']),

This seems like an obvious solution. I wonder if the maintainer has any concern over it and deliberately not implementing it. @xiaozhu36

[xiaozhu36]

Hi everyone, I am sorry for late reply. At present the tags has been supported. Please check https://github.com/alibaba/ansible-provider/blob/master/lib/ansible/modules/cloud/alicloud/ali_instance_info.py#L54