aliyun / acr-login Goto Github PK
View Code? Open in Web Editor NEWLicense: Apache License 2.0
License: Apache License 2.0
Why change the tag from v1
to V1
, which will cause all the existing jobs to fail?
Hi,I use the following config to login ACR:
- name: Login to ACR with the AccessKey pair
uses: aliyun/acr-login@v1
with:
region-id: "cn-hangzhou"
access-key-id: "${{ secrets.ACK_ACCESS_KEY_ID }}"
access-key-secret: "${{ secrets.ACK_ACCESS_KEY_SECRET }}"
It returns the following error:
Is there something I missed?
I was experimenting with aliyun
command line client against cr Personal Edition. It seems the aliyun cr GetAuthorizationToken
command only supports 2016-06-07 API for now
Invoking aliyun --access-key-id "$ak" --access-key-secret "$sk" --region cn-beijing cr GetAuthorizationToken
will fail with the following error, with http status code being 404 (req id: 77C730C7-CE62-51FD-AC39-2658DCF9EE05
). The aksk was for a RAM user with AdministratorAccess role policy.
Same command but with access key created from "AccessKey Management" works just fine.
My end goal is to use aksk from a RAM user with only permission to access specified repo. Aksk from "AccessKey Management" does not pertain to the least permission security practice.
Run denverdino/acr-login@v10s
}
Run denverdino/acr-login@v1
with:
login-server: registry.cn-hangzhou.aliyuncs.com
region-id: cn-hangzhou
access-key-id:
access-key-secret:
internal/modules/cjs/loader.js:800
throw err;
^
Error: Cannot find module '@actions/core'
Require stack:
In my test, when successfully logging to ACR, it will print the information as below:
I also went through the code and found out the information below indicates successful login.
Run aliyun/acr-login@v1
with:
login-server: https://kubevela-registry.cn-hangzhou.cr.aliyuncs.com
username: ***
password: ***
region-id: cn-hangzhou
env:
BUCKET: ***
ENDPOINT: ***
ACCESS_KEY: ***
ACCESS_KEY_SECRET: ***
ARTIFACT_HUB_REPOSITORY_ID: ***
DOCKER_CONFIG environment variable is set
How about we appending some similar information as below?
...
Successfully login to ACR.
When utilizing this action with other Docker registries (ie ghcr, aws) this action blows out configurations and breaks usage. This is because of the quite abrupt approach this action takes (writing config files manually)
https://github.com/aliyun/acr-login/blob/master/src/login.js#L88-L94
Any reason the action does this?
I was looking into ecr-login which just invokes docker login
which appears far less damaging in its execution: https://github.com/aws-actions/amazon-ecr-login/blob/main/index.js#L161
i follow the readme example, set USER_NAME and PASSWORD,github action login success but push fails
below is github action config file:
- name: Check out the repo
uses: actions/checkout@v2
- name: Login to ACR
uses: aliyun/acr-login@v1
with:
login-server: https://registry.cn-beijing.aliyuncs.com
region-id: cn-beijing
username: "${{ secrets.USERNAME }}"
password: "${{ secrets.PASSWORD }}"
- name: Build and push image
env:
IMAGE_TAG: latest
run: |
docker build -t registry.cn-beijing.aliyuncs.com/tmoe/resume_web:$IMAGE_TAG .
docker push registry.cn-beijing.aliyuncs.com/tmoe/resume_web:$IMAGE_TAG
below is action fail screenshot:
I try to exec docker push registry.cn-beijing.aliyuncs.com/tmoe/resume_web:$IMAGE_TAG
on my local machine, and it works, but github action can not work. before use acr, i push to dockerhub, it works too.
I have noticed that PR #17 has been merged just now.
Could you please release a new version or create a new tag?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.