alkesst / dev-chat

A chat in a local network

Hello there

Music 🎸

Stats 📊

dev-chat's Issues

Bug when leaving the client

OS:

• Manjaro with kernel 4.14

VERSION DEV-CHAT:

• Dev-Chat 1.0

ISSUE:

• When the server shuts down and once left the client, the terminal does not show the text you type in it until you reset it. Error could be generated in line 154 in chat_client.c

Client bug when server shut downs

OS:

macOs High Sierra 10.13.2

VERSION DEV-CHAT:

1.0

ISSUE:

The client don't close when enter is pressed after the server shuts down.

Invalid passing pointer when creating the thread

https://github.com/Alkesst/Dev-Chat/blob/master/client/chat_client.c#L113

The thread expects a struct Client* object but when creating it, the pthread_create receives a int*.

This call must pass the client object, not the socket.

But it is good to know that this code doesn't make a t h i c c crash, mainly because the socket is the first element of the structure and has the same memory address of the client structure.

Non-ASCII characters are not sent correctly in the client

OS:
// Current OS system and version
macOS 10.12.6 / Manjaro 17

VERSION DEV-CHAT:
// Current version of Dev-Chat
1.0.1

ISSUE:
// Description of the issue
Non-ASCII characters are discarded due to the reading byte by byte. The client should read the keyboard input using wide characters wchar_t, and ensuring the input is imbued using the locale of the user.