allendowney / dsirp Goto Github PK

Hey Allen, in the recursion factorial exercise, you describe raising x to an integer power, but then use n in instructions:

Trying to load the Algorithms Notebook:

https://mybinder.org/v2/gh/AllenDowney/DSIRP/master?urlpath=tree/algorithms.ipynb

Binder says it cannot find it!

Got a error box when I clicked on the left side link labeled "search"

https://github.com/AllenDowney/DSIRP/blob/main/notebooks/search2.ipynb returns 404

where it says, "element = soup.contents[0]" it should say "element = soup.contents[1]" so that it goes to the Tag element and not the NavigableString element

https://colab.research.google.com/github/AllenDowney/DSIRP/blob/main/chapters/algorithms.ipynb

I changed chapters to notebooks and it works just fine!

In chapter Getting to Philosophy, when function link_generator is called with soup based on Python's Wikipedia Page, an error, IndexError: pop from empty list, will be detected while executing the following block:

            for char in element.string:
                if char == '(':
                    paren_stack.append(char)
                if char == ')':
                    paren_stack.pop()

It is simply because the web page contains half-open intervals (i.e. [0, b) as shown below), and ')' is detected when there is no '(' in paren_stack.

It can be ignored by checking if paren_stack is empty first, but the other type of half-open interval - (b, 0] (which is in the same sentence) - would cause another trouble: all the text after (b, 0] would be considered as inside parentheses. Maybe just start with another page instead of Python, for demonstration purpose?

I would love to see if you have any solution to this issue. Thanks.

Thanks for all your work, enjoying the material.

I think there is a typo on Testing Order of Growth Page
'''
We’ll handle it by running over a wide range of problem sizes, hoping to sizes that run long enough to measure, but not more than a few seconds.
'''
Is hoping supposed to be hopping?