alosada7 / edene Goto Github PK

Look at another libraries that uses emotion. For example:

• The Guardian Source
• Material UI

Or at least doc:

• ThemeProvider
• ToastProvider
• ModalProvider
• ...

For consumers to be able to reduce their LCP, we need to ensure the first image is loaded eagerly in carousel.

It would be good to add stories to the Carousel component in order to be able to check different states

Use the same documentation you have in the Storybook.
Present it as a list

Example: https://github.com/vercel-labs/simorgh

Use the following Badge but with the actual link to add Storybook to your README

• Register new page in template. Also make routes more dynamic
• Create mocks (2 results)
• Component which renders a list with mocks data
• No results template

When building, Nx takes @edene/foundations & @emotion/react as peer-dependencies, which means that the consumer has to install them individually.

We can skip this step and make easy for the user start working with our library

Possible values are

• info
• success
• danger
• warning
• grey

We are moving all template pages to Storybook, so we have more control on the responsiveness.

To do this, we will move it under a template folder following the same structure they already have. We will export them and make the library publishable (@edene/pro-labs)

We will import them into their actual component so we conserve laziness.

In Storybook, other folders will keep components, charts, forms, tricks, ... try to organise them as clear as possible

All that is not using edene components should be in the Laboratory folder. Remember to review that the same happens to edene components which still have not been published (in components)

Use Stack & Group components instead

We want to reduce the number of cases in which icon is passed as a string to a component. The reason to do this is be able to use both fixed & outlined icons.

For the cases a fixed size is necessary, the best solution would be override it

Incompatible API changes might occur. For that is the case,add the new behaviour, log a warning when a string is being passed as parameter, and mark this ticket with a label called v2

To allow it use Next Image component, for example

Two stories that do the same
Update provider

Remove it from preview.js once it is possible. Also pass this files to ts and clean them