alphagov / calculators

Serves the Child benefit tax calculator on GOV.UK

This service is now provided by Smart Answers

Child Benefit tax calculator

This calculator reports how much child benefit tax you are entitled during a tax year.

There is a cut-off date of 7 January 2013. This is the date High Income Child Benefit Tax Charge came in effect. This means that if the 2012 tax year is selected the calculator will only calculate the child benefit you are entitled to from 7 Jan 2013 to 5 Apr 2013, not for the entire tax year.

Running the app

./startup.sh

To run the app with the live content store and static

./startup.sh --live

The only content in this app is child-benefit-tax-calculator/main

Running tests

bundle exec rake spec

Dependencies

• publishing-api: this app sends data to publishing-api to register URLs.

calculators's Issues

Warning: the gem 'govuk_frontend_toolkit' was found in multiple sources.

Running bundle install for the first time results in the following warning:

Warning: the gem 'govuk_frontend_toolkit' was found in multiple sources.
Installed from: https://gem.fury.io/govuk/
Also found in:
  * https://rubygems.org/
You should add a source requirement to restrict this gem to your preferred source.
For example:
    gem 'govuk_frontend_toolkit', :source => 'https://gem.fury.io/govuk/'
Then uninstall the gem 'govuk_frontend_toolkit' (or delete all bundled gems) and then install again.

Subsequent runs of bundle install result in the following warning:

Warning: this Gemfile contains multiple primary sources. Using `source` more than once without a block is a security risk, and may result in installing unexpected gems.
To resolve this warning, use a block to indicate which gems should come from the secondary source. To upgrade this warning to an error, run `bundle config disable_multisource true`.

I can avoid the second warning by specifying the source of the 'govuk_frontend_toolkit' gem in either of the following two ways:

source 'https://[email protected]/govuk/' do
  gem 'govuk_frontend_toolkit', '0.20.0'
end

# or

gem 'govuk_frontend_toolkit', '0.20.0', source: 'https://[email protected]/govuk/'

Even with the above changes, if I remove my bundled gems directory and then re-run bundle install I still see the original warning.

This doesn't prevent anything from working but it's still somewhat frustrating.

Update form styles to use form components

Calculators uses the latest form styles from Elements. It should instead use the styles that government-frontend and now email-alert-frontend use, by reusing the form components in govuk_publishing_components.

eg
https://government-frontend.herokuapp.com/component-guide/radio
https://government-frontend.herokuapp.com/component-guide/error_summary

Dependabot can't resolve your Ruby dependency files

Dependabot can't resolve your Ruby dependencies.

As a result, Dependabot couldn't update any of your dependencies.

This could have been caused by a git reference having been deleted at the source, by an out-of-sync lockfile, or by a bug in Dependabot.

To help diagnose the issue, please try running bundle update --patch locally. If no errors occur, get in touch and we'll help dig into it.

You can mention @dependabot in the comments below to contact the Dependabot team.

Weird highlighting on Results #h2

When you complete the child benefit tax calculator, you end up at a URL like this one

There is weird highlighting around the Results tag, which disappears when it goes out of focus. (ie click on another part of the page)

Long URL error not logged to Erbit

The calculator currently passes all input values as GET, meaning that it's possible to create very long URLs by typing long values into the form (for normal use this shouldn't be a problem for modern browsers, although attempting to claim for part of the year for 10 children can result in a URL of length > 3000 chars, limit for older IE is 2000).

If you trigger this, for example by putting in a ridiculously long number into each of the number fields, it triggers a 500 error, but it doesn't appear that this is being logged correctly in Erbit.