alphagov / collections

Serves GOV.UK navigation pages, browse, topic, step-by-steps & services and information pages.

Collections

Collections serves the GOV.UK navigation pages and organisation pages. Search API is used to make the pages dynamic e.g. the latest changes for Topics, Organisations and Mainstream browse pages.

At time of writing, it also serves the priority campaign pages. See the Campaign pages manual for more details.

Live examples

• Browse page: gov.uk/browse
• Topic page: gov.uk/oil-and-gas
• Subtopic page: gov.uk/oil-and-gas/fields-and-wells
• Taxonomy page: gov.uk/education
• Worldwide taxonomy page: gov.uk/world/japan
• Organisation index page: gov.uk/government/organisations
• Organisation page: gov.uk/government/organisations/cabinet-office
• Step by step page: gov.uk/learn-to-drive-a-car
• Past Prime Minister: gov.uk/government/history/past-prime-ministers/tony-blair
• World index page: gov.uk/world

Nomenclature

Topics

• Curated list: a group of content tagged to a subtopic that has been curated into a named list.
• Topic: a named group of sub-topics. (A deprecated name for this is "specialist sector".)
• Sub-topic: a group of content within a topic. (A deprecated name for this is "specialist sub-sector".)

Technical documentation

This is a Ruby on Rails app, and should follow our Rails app conventions.

You can use the GOV.UK Docker environment or the local startup.sh script to run the app. Read the guidance on local frontend development to find out more about each approach, before you get started.

If you are using GOV.UK Docker, remember to combine it with the commands that follow. See the GOV.UK Docker usage instructions for examples.

Running the test suite

bundle exec rake

To test a single file:

bundle exec rails test test/unit/application_helper_test.rb

To run JavaScript tests (only):

bundle exec rake jasmine

Pact tests

Collections Organisations API has a pact with GDS API Adapters.

See the guidance on Pact testing for how to run and modify the tests.

Further documentation

• Taxonomy pages
• Campaign pages
• API endpoints and consumers

Licence

MIT License

collections's Issues

Dependabot can't resolve your Ruby dependency files

Dependabot can't resolve your Ruby dependencies.

As a result, Dependabot couldn't update any of your dependencies.

This could have been caused by a git reference having been deleted at the source, by an out-of-sync lockfile, or by a bug in Dependabot.

To help diagnose the issue, please try running bundle update --patch locally. If no errors occur, get in touch and we'll help dig into it.

You can mention @dependabot in the comments below to contact the Dependabot team.

Root browse page content hidden when going from a large width viewport to small

A bit of an edge case but I've noticed if you load the browse page then decrease the viewport width, the content is hidden.

This only happens on https://www.gov.uk/browse

Browse and description links are too tight

There should be 5px padding below the heading

Padding on 'taxon email link' is big on small screens.

Noticed this on my phone

Update testing - accordion

What

Testing for accordion to be updated

Why

The Accordion is now coming from GOVUK Design System and build upon within govuk_publishing_components
as a result current testing is no longer accurate, some can be removed with specific testing relating to tracking to be maintained.

Example files
https://github.com/alphagov/collections/blob/main/spec/javascripts/modules/coronavirus-landing-page_spec.js#L4
https://github.com/alphagov/collections/blob/main/spec/javascripts/modules/coronavirus-landing-page_spec.js#L57
https://github.com/alphagov/collections/blob/main/app/assets/javascripts/modules/coronavirus-landing-page.js#L43

No.10 page text in 'Contact Number 10' section too small

The body text in the 'Contact Number 10' section of https://www.gov.uk/government/organisations/prime-ministers-office-10-downing-street looks too small - it's 16px.

The <p> tag should probably have a class of govuk-body applied to it, improving the font size to 19px and making it consistent with the rest of the page.

Currently:

With govuk-body class:

Government organisations page search has a big gap

On https://www.gov.uk/government/organisations

If you search for something that happens to be at the bottom of the page, you might be forgiven for thinking your search hasn't found anything, because you might get this result and your browser window might not be tall enough:

The reason for this is that each of the wrappers to each organisation type has a margin bottom of 60px, and the search only hides the individual items within each wrapper, not the wrapper itself:

Surprisingly on mobile, this isn't a problem, even though the margin bottom is still there, each wrapper collapses over the next one.

X-Frame-Options

X-Frame-Options: allowall HTTP header has been enabled on the GDS pages since 2015 by this commit which at best looks unprofessional and at worst opens additional possibilities for fraud by allowing GDS pages to be embedded in frames.

Per my comment under that commit, if there's still need to allow frames for some origins as part of the transition, a much safer allow-from option exists for that purpose.

Convert tests from Minitest to RSpec

Issue

• We are currently implementing Pact tests between Collections and gds-api-adapters in order to meet the criteria for CD of collections.
• The pact gem brings in RSpec as a dependency. This will mean Collections runs two test suites, Minitest and RSpec.
• This is not necessarily bad, eg Smart Answers also has both suites. However in the case of collections it adds a little bit of complexity. Collections uses cucumber for its feature tests, and they fail without patching the Minitest assertions methods.
• RSpec is the GDS testing frame work of choice, so it is probably worth taking the plunge and converting to Minitest.

TO DO

Regular tests

There is a rake task that can be used to do some of the syntax conversion.

bundle exec rake convert:to_rspec\["test/components","spec/views/components"\]

Convert the following

• test/components
• test/controllers
• test/integration
• test/lib
• test/models
• test/models/schemas
• test/models/topic
• test/presenters
• test/presenters/organisations
• test/presenters/supergroups
• test/services
• test/services/search
• test/services/supergroup_sections
• test/unit

Once all tests requiring a specific helper have been ported over to RSpec, move the helpers from test/support ==> spec/support

• analytics_helper
• coronavirus_helper
• coronavirus_landing_page_steps
• custom_assertions
• dit_landing_page_helper
• gds_api_rummager_test_helpers
• helpers
• organisation_feed_helpers
• organisation_helper
• organisations_helpers
• rummager_helpers
• services_and_information_helpers
• supergroups_helpers
• taxon_helpers
• transition_landing_page_steps

Feature tests

Convert features/step_definitions

• browsing_topics_steps
• curated_list_steps
• latest_changes_steps
• viewing_browse_steps
• viewing_services_and_information_steps

Convert or remove files in features/support as required

Tidy up

• remove Dir[Rails.root.join("test/support/**/*.rb")].sort.each { |f| require f } from spec_helper.
• Remove test_helper

Brexit.cy incorrect/missing lang attributes

The Welsh language version of the Brexit page has large chunks of English language content without appropriate lang attributes which is an accessibility problem. The bits of content which are in English should be identified with lang="en" so that screenreader software reads them out properly.

Additionally, the links in the bottom section (a part of the page which actually is in Welsh) has lang="en" which means it is not read out correctly by AT (for instance on that portion of the page VoiceOver on Mac reads the character â as "a-circumflex" as can be heard in the recording below)

Screen.Recording.2021-12-14.at.17.09.19.mov

---

https://www.w3.org/TR/UNDERSTANDING-WCAG20/meaning-other-lang-id.html

Browse columns show two active categories

Presumably caused by a partial slug match (child matches both /child and /child-adoption)

URL: https://www.gov.uk/browse/births-deaths-marriages/child-adoption
Screen capture

Animation jank on slower devices

Issue found while visiting the Scottish Government's Device Lab

Animation of the browse page does not perform ideally on slower devices.

https://drive.google.com/file/d/0B-GzTJBVVSNzaUE1RktkRmxpTnM/view?usp=sharing
https://drive.google.com/file/d/0B-GzTJBVVSNzQ1lJaEtBbDFCZ2M/view?usp=sharing

Possible solutions could include using animation of transform instead of margin-left or not animating at all on slower devices (don't use JavaScript)

Breadcrumbs are not wrapped in a container

On smaller viewports the breadcrumbs do not have the correct padding.

Browse page content disappears when resizing window

When resizing the browser window from large to small, the browse page contents disappear.

Steps to replicate:

1. Make sure browser window is more than 640 pixels wide
2. Go to https://www.gov.uk/browse
3. Resize window to less than 640 pixels wide

More than 640pixels wide	Less than 640 pixels wide

Slow browse page in poor connection circumstances

Issue found while visiting the Scottish Government's Device Lab

https://drive.google.com/file/d/0B-GzTJBVVSNzSzNxT00zODZyUVk/view?usp=sharing

Can be reproduced with the Chrome Dev tools network throttling.

We could consider making the /browse page work offline-first, so the navigation is all cached locally on the device.

Who maintains machinery of government data and how can I contact them?

Can you please point me in the direction of the person who maintains the organisations database? Sorry if this is the wrong place for this sort of thing, I can't find anything anywhere else!

I am performing a data collection exercise across government and have been using the gov-uk-organisations API. In the course of the exercise I am coming across occasional instances of outdated / incorrect information and I would like to help fix it.

So far I've identified:

• Directly Operated Railways Ltd no longer exists but is still showing as a live organisation.
• Bank of England is showing as an ALB of the Treasury Solicitor’s Department, which no longer exists.
• Assessor of Compensation for Miscarriages of Justice does not have an entry but exists according to MoJ.

Link items in browse columns have old focus states

Make use of the `prefers-reduced-motion` media query

I opened a similar issue on twbs/bootstrap, I'd be interested to know your thoughts.

Is there any interest in supporting the prefers-reduced-motion media query? It's currently only honoured in Safari (MacOS/iOS), but pretty much, if a user has set in their browser/system preferences they'd like reduce the amount of motion they see, we can know about.

An example implimenation would be replacing browse-columns.js:16 with something more like (thanks @robinwhittleton )

this.animateSpeed = window.matchMedia && window.matchMedia("(prefers-reduced-motion: reduce)") ? 0 : 330;