alyf-de / erpnext_germany Goto Github PK

View Code? Open in Web Editor NEW

35.0 35.0 20.0 2.95 MB

ERPNext customizations for German companies

License: GNU General Public License v3.0

Python 88.30% JavaScript 11.70%

erp erpnext germany

erpnext_germany's People

Contributors

Stargazers

Watchers

Forkers

mohsinalimat fhenry hrwx jango-blockchained bernhein intellimomentum corebiz-engineering revasiya marination bosue digitalgewerk 0xd0m1m0 scdanieli joenyzio empress-eco shivansh12 patrickdeissler

erpnext_germany's Issues

Customer VAT vs. Trader name etc.

Nice VAT checker!
A feature ERPNext should definitely ship with IMO, after getting polished a little bit. Finally, every company in the EU needs this functionality, plus quite a few abroad who do a lot of business with the EU.

The terminology however confused me quite a bit. The VAT field itself explicitly refers to customers, while all other fields refer to some trader. With the English interface, it also took me a bit to understand that the difference doesn‘t seem to be on purpose:

We neither want to limit the VAT feature to customers nor to traders or suppliers. So how about referring to „Business Partners“ or simply „Counterparty“? There are a few more – and more important – things to do, but it makes sense to start with a proper, consistent terminology. So if you agree and support one or the other choice of terminology, I can readily post a PR.

VAT ID and Tax ID should be two different fields

The doctype "VAT_ID_Check" is fetching the values for "Customer VAT ID" field from "customer.tax_id" and the field value for "Requester VAT ID" is fetching from "company.tax_id"

The "customer.tax.id" is the "Steuernummer" of the customer.
The "company.tax_id" field is representing the "Steuernummer" of the company

"Steuernummer"(Tax ID) is different from "USt-IdNr"(VAT ID).
This is somehow misleading if Tax ID is used for VAT ID. these should be two different fields.

There is no "VAT ID" field by default in ERPNext. We created a custom field for the "USt-IdNr." in the customer doctype

Maybe it is a good idea to add a custom field e.g. "Customer VAT ID" and fetch from there.

App Versions

{
	"erpnext": "13.27.0",
	"erpnext_germany": "0.0.1",
	"erpnextfints": "0.4.1",
	"frappe": "13.26.1",
	"german_accounting": "0.0.1"
}

Route

Form/Supplier/XXXX

Trackeback

Traceback (most recent call last):
  File "apps/frappe/frappe/app.py", line 69, in application
    response = frappe.api.handle()
  File "apps/frappe/frappe/api.py", line 55, in handle
    return frappe.handler.handle()
  File "apps/frappe/frappe/handler.py", line 37, in handle
    data = execute_cmd(cmd)
  File "apps/frappe/frappe/handler.py", line 75, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "apps/frappe/frappe/__init__.py", line 1447, in call
    return fn(*args, **newargs)
  File "apps/erpnext_germany/erpnext_germany/api.py", line 7, in validate_vat_id
    from .utils.eu_vat import is_valid_eu_vat_id
  File "apps/erpnext_germany/erpnext_germany/utils/eu_vat.py", line 1, in <module>
    import zeep
ModuleNotFoundError: No module named 'zeep'

Request Data

{
	"type": "POST",
	"args": {
		"vat_id": "DE XXXXX"
	},
	"headers": {},
	"error_handlers": {},
	"url": "/api/method/erpnext_germany.api.validate_vat_id"
}

Response Data

{
	"exception": "ModuleNotFoundError: No module named 'zeep'"
}

VAT ID Check: KeyError

Reproduce

VAT ID Check: Select Party Address field before a Party is selected.

App Versions

{
	"erpnext": "15.11.0",
	"erpnext_germany": "15.1.1",
	"frappe": "15.12.0"
}

Route

Form/VAT ID Check/new-vat-id-check-kuntuoglke

Traceback

Traceback (most recent call last):
  File "apps/frappe/frappe/app.py", line 110, in application
    response = frappe.api.handle(request)
  File "apps/frappe/frappe/api/__init__.py", line 49, in handle
    data = endpoint(**arguments)
  File "apps/frappe/frappe/api/v1.py", line 36, in handle_rpc_call
    return frappe.handler.handle()
  File "apps/frappe/frappe/handler.py", line 49, in handle
    data = execute_cmd(cmd)
  File "apps/frappe/frappe/handler.py", line 85, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "apps/frappe/frappe/__init__.py", line 1684, in call
    return fn(*args, **newargs)
  File "apps/frappe/frappe/utils/typing_validations.py", line 31, in wrapper
    return func(*args, **kwargs)
  File "apps/frappe/frappe/desk/search.py", line 47, in search_link
    results = search_widget(
  File "apps/frappe/frappe/utils/typing_validations.py", line 31, in wrapper
    return func(*args, **kwargs)
  File "apps/frappe/frappe/desk/search.py", line 95, in search_widget
    return frappe.call(
  File "apps/frappe/frappe/__init__.py", line 1684, in call
    return fn(*args, **newargs)
  File "apps/frappe/frappe/utils/typing_validations.py", line 31, in wrapper
    return func(*args, **kwargs)
  File "apps/frappe/frappe/__init__.py", line 2423, in wrapper
    return fn(**kwargs)
  File "apps/frappe/frappe/contacts/doctype/address/address.py", line 276, in address_query
    link_name = filters.pop("link_name")
KeyError: 'link_name'

Request Data

{
	"type": "POST",
	"args": {
		"txt": "",
		"doctype": "Address",
		"ignore_user_permissions": 0,
		"reference_doctype": "VAT ID Check",
		"page_length": 10,
		"query": "frappe.contacts.doctype.address.address.address_query",
		"filters": "{\"link_doctype\":\"Customer\"}"
	},
	"headers": {},
	"error_handlers": {},
	"url": "/api/method/frappe.desk.search.search_link",
	"request_id": null
}

Response Data

{
	"exception": "KeyError: 'link_name'",
	"exc_type": "KeyError"
}

alyf-de / erpnext_germany Goto Github PK

erpnext_germany's People

Contributors

Stargazers

Watchers

Forkers

erpnext_germany's Issues

App Versions

Route

Trackeback

Request Data

Response Data

Reproduce

App Versions

Route

Traceback

Request Data

Response Data

Recommend Projects

Recommend Topics

Recommend Org

Jobs