amatino-code / amatino-mac Goto Github PK

Global and Custom units may have arbitrary minimum fractions. For example a U.S. Dollar's smallest fraction is cents (two fractional digits) while a Bitcoin might have a Satoshi as its smallest fraction (six fractional digits). While the Amatino API fully supports such arbitrary fractions, Amatino Mac is currently hard-coded with two fractional digits. For example, in TabularAmountInput:

init(
        frame frameRect: NSRect,
        side: Side
) {
        self.side = side
        super.init(frame: frameRect)
        numberFormatter.locale = Locale.current
        numberFormatter.numberStyle = .decimal
        numberFormatter.currencySymbol = nil
        numberFormatter.minimumIntegerDigits = 1
        numberFormatter.minimumFractionDigits = 2 // <- bad!
        numberFormatter.maximumFractionDigits = 2 // <- bad!

//...

To resolve this issue, various input classes will need to be able to receive and adapt to supplied Global and Custom unit fractional digit sizes.

When tabbing along the ledger input row, all is well until you attempt to reverse shift-tab back from the debit input field. A further shift-tab will take you from the account field to the debit field again. This appears to be a result of a monkey-patch applied to the tabular account selection NSView subclass, which itself "solved" 🙄 a bug wherein the tabular account selection would not enter the responder chain at all.