amaurycarrade / flarum-ext-syndication Goto Github PK

View Code? Open in Web Editor NEW

19.0 19.0 11.0 326 KB

Brings RSS and Atom feeds to Flarum

License: Other

PHP 93.15% JavaScript 2.96% Less 0.23% Blade 3.66%

atom-feed discussion feed flarum flarum-ext flarum-extension syndication

flarum-ext-syndication's People

Contributors

Stargazers

Watchers

Forkers

ogioncz 0xffff-one splitbrain-forks gudzpoz

flarum-ext-syndication's Issues

PHP error

Hi,
This error shows up when I open a feed:

Undefined property: stdClass::$editedAt

You can check that here: https://community.maicol07.it/atom/dx/6-scheduled-exams-1-0-apatite
How do I fix it?
Thanks

Last-Modified header

Hello, it'll be great if /rss and /atom responds with proper Last-Modified header for responses caching.

Beta 14/Mithril 2 support?

Will this extension get Beta 14/Mithril 2 support?

Content Type

Might want to fit this into your code somewhere.
header('Content-Type: application/xml');

Error 500

After the transition of the site to https Protocol extension stopped working. On transition to /atom and / rss gives an error 500

License

You should switch to the MIT license or somehow make it so you don't need to put the whole license at the top of each file.

URLs readability

I have a small proposal to make urls more readable.
Right now you append /d to an url to output feed with discussions. It's not really obvious.

How about that:
/atom/posts - for feed with posts
/atom/discussions - for feed with discussions
/atom - defaults to /posts

Same thing for tags, users, etc.

I'm using the Syndication extension to trigger an IFTTT applet. However, IFTTT requires the feed to be valid for it to work, and the extension isn't generating valid feeds (both RSS and Atom). Some data are returning just 1, when it should be a post URL, for example.

You can check the validator results for my feed here. I'm using Beta 10.

str_ helper methods have been removed in beta 14, starts_with error

This extension uses starts_with in multiple places.

That method has been removed in the beta 14 update of Flarum https://docs.flarum.org/extend/update-b14.html#removals

Error 500 on some urls

error on my log file.

[2020-03-30 05:36:30] production.ERROR: TypeError: Argument 2 passed to AmauryCarrade\FlarumFeeds\Controller\AbstractFeedController::getRelationship() must be an instance of stdClass, null given, called in /flarum/app/vendor/amaurycarrade/flarum-ext-syndication/src/Controller/DiscussionFeedController.php on line 104 and defined in /flarum/app/vendor/amaurycarrade/flarum-ext-syndication/src/Controller/AbstractFeedController.php:207
Stack trace:
#0 /flarum/app/vendor/amaurycarrade/flarum-ext-syndication/src/Controller/DiscussionFeedController.php(104): AmauryCarrade\FlarumFeeds\Controller\AbstractFeedController->getRelationship(Object(stdClass), NULL)
#1 /flarum/app/vendor/amaurycarrade/flarum-ext-syndication/src/Controller/AbstractFeedController.php(123): AmauryCarrade\FlarumFeeds\Controller\DiscussionFeedController->getFeedContent(Object(Laminas\Diactoros\ServerRequest))
#2 /flarum/app/vendor/flarum/core/src/Http/RouteHandlerFactory.php(38): AmauryCarrade\FlarumFeeds\Controller\AbstractFeedController->handle(Object(Laminas\Diactoros\ServerRequest))
#3 /flarum/app/vendor/flarum/core/src/Http/Middleware/DispatchRoute.php(65): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}(Object(Laminas\Diactoros\ServerReque
st), Array)
#4 /flarum/app/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\DispatchRoute->process(Object(Laminas\Diactoros\ServerRequest), Object(Closu
re))
#5 /flarum/app/vendor/flarum/core/src/Http/Middleware/ShareErrorsFromSession.php(56): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#6 /flarum/app/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\ShareErrorsFromSession->process(Object(Laminas\Diactoros\ServerRequest), Obj
ect(Laminas\Stratigility\Next))
#7 /flarum/app/vendor/flarum/core/src/Http/Middleware/SetLocale.php(50): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#8 /flarum/app/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\SetLocale->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\S
tratigility\Next))
#9 /flarum/app/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(23): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#10 /flarum/app/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\CheckCsrfToken->process(Object(Laminas\Diactoros\ServerRequest), Object(Lam
inas\Stratigility\Next))
#11 /flarum/app/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(32): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#12 /flarum/app/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\AuthenticateWithSession->process(Object(Laminas\Diactoros\ServerRequest), O
bject(Laminas\Stratigility\Next))
#13 /flarum/app/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(51): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#14 /flarum/app/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\RememberFromCookie->process(Object(Laminas\Diactoros\ServerRequest), Object
(Laminas\Stratigility\Next))
#15 /flarum/app/vendor/flarum/core/src/Http/Middleware/StartSession.php(61): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#16 /flarum/app/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\StartSession->process(Object(Laminas\Diactoros\ServerRequest), Object(Lamin
as\Stratigility\Next))
#17 /flarum/app/vendor/flarum/core/src/Http/Middleware/CollectGarbage.php(46): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#18 /flarum/app/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\CollectGarbage->process(Object(Laminas\Diactoros\ServerRequest), Object(Lam
inas\Stratigility\Next))
#19 /flarum/app/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(28): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#20 /flarum/app/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\ParseJsonBody->process(Object(Laminas\Diactoros\ServerRequest), Object(Lami
nas\Stratigility\Next))
#21 /flarum/app/vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#22 /flarum/app/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\HandleErrors->process(Object(Laminas\Diactoros\ServerRequest), Object(Lamin
as\Stratigility\Next))
#23 /flarum/app/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(84): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#24 /flarum/app/vendor/middlewares/request-handler/src/RequestHandler.php(84): Laminas\Stratigility\MiddlewarePipe->process(Object(Laminas\Diactoros\ServerRequest), Obj
ect(Laminas\Stratigility\Next))
#25 /flarum/app/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\RequestHandler->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Strati
gility\Next))
#26 /flarum/app/vendor/middlewares/base-path-router/src/BasePathRouter.php(97): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#27 /flarum/app/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\BasePathRouter->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Strati
gility\Next))
#28 /flarum/app/vendor/laminas/laminas-stratigility/src/Middleware/OriginalMessages.php(42): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#29 /flarum/app/vendor/laminas/laminas-stratigility/src/Next.php(61): Laminas\Stratigility\Middleware\OriginalMessages->process(Object(Laminas\Diactoros\ServerRequest),
 Object(Laminas\Stratigility\Next))
#30 /flarum/app/vendor/middlewares/base-path/src/BasePath.php(53): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#31 /flarum/app/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\BasePath->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility
\Next))
#32 /flarum/app/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(84): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#33 /flarum/app/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(73): Laminas\Stratigility\MiddlewarePipe->process(Object(Laminas\Diactoros\ServerRequest), Ob
ject(Laminas\Stratigility\EmptyPipelineHandler))
#34 /flarum/app/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(96): Laminas\Stratigility\MiddlewarePipe->handle(Object(Laminas\Diactoros\ServerRe
quest))
#35 /flarum/app/vendor/flarum/core/src/Http/Server.php(42): Laminas\HttpHandlerRunner\RequestHandlerRunner->run()
#36 /flarum/app/public/index.php(26): Flarum\Http\Server->listen()
#37 {main}

Fix compatibility with flarum 0.1.0beta.8

Flarum 0.1.0beta.8 dropped ControllerInterface in favour of PSR-15 interface.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.

Jobs

Jooble