Add error summary at the end of `ament test` about ament_tools

[dirk-thomas]

That sounds like a good improvement to me. The summary should probably only show the results from the packages processed by the test verb.

[gerkey]

Though not strictly related to the idea of printing the test summary, I'm also looking at making ament test return non-zero when a test fails. I found this chunk of code:

https://github.com/ament/ament_tools/blob/master/ament_tools/verbs/test/cli.py#L50-L63

which seems intended to do exactly that. But it always returns zero, apparently because of this chunk of code:

https://github.com/ament/ament_tools/blob/master/ament_tools/verbs/test_pkg/cli.py#L76-L89

which explicitly discards the return code from testing an individual package.

I don't know the history here. @dirk-thomas, should I try to (re-)enable proper return code handling, or not bother?

[dirk-thomas]

Please see ros-infrastructure/ros_buildfarm#367 (comment) for a rational why ament test intentionally returns zero if the tests have been run even if some tests failed.

[dirk-thomas]

Closing since the repo is archived.