deIndex is being called wrong about ampersand-collection

[wraithgar]

Also, what happens if any other attribute in this.indexes change?

[wraithgar]

Maybe

    _onModelEvent: function (event, model, emitter, options) {
        var attribute = event.split(':')[1];
        event = event.split(':')[0];
        if ((event === 'add' || event === 'remove') && emitter !== this) return;
        if (event === 'destroy') this.remove(model, options);
        if (model && event === 'change' && this._indexes[attribute]) {
            this._deIndex(emitter);
            this._index(model);
        }

[chabou]

In case of single attribute change, emitter is the new value of this attribute.
Maybe we could use previousAttributes()

var attribute = event.split(':')[1];
        event = event.split(':')[0];
        if ((event === 'add' || event === 'remove') && emitter !== this) return;
        if (event === 'destroy') this.remove(model, options);
        if (model && event === 'change' && this._indexes[attribute]) {
            this._deIndex(model.previousAttributes());
            this._index(model);
        }

[wraithgar]

this._deIndex(model, attribute, value)

This would require deIndex to be given the index value too, much like it can be given the specific index/

[chabou]

ok but maybe optional parameters. If they aren't passed to the method, we loop on all model attributes. (useful for _addReference)

We could do the same for _index

[chabou]

Can I fill a PR ? Even if you don't accept my changes, I added some useful test cases.

[wraithgar]

@chabou this issue is 100% intended for someone who has the time to write up a PR for this THANK YOU SO MUCH if you have the time.

[lukekarrys]

Closed by #47