GithubHelp home page GithubHelp logo

Comments (8)

wraithgar avatar wraithgar commented on August 24, 2024

Also, what happens if any other attribute in this.indexes change?

from ampersand-collection.

wraithgar avatar wraithgar commented on August 24, 2024

Maybe

    _onModelEvent: function (event, model, emitter, options) {
        var attribute = event.split(':')[1];
        event = event.split(':')[0];
        if ((event === 'add' || event === 'remove') && emitter !== this) return;
        if (event === 'destroy') this.remove(model, options);
        if (model && event === 'change' && this._indexes[attribute]) {
            this._deIndex(emitter);
            this._index(model);
        }

from ampersand-collection.

chabou avatar chabou commented on August 24, 2024

In case of single attribute change, emitter is the new value of this attribute.
Maybe we could use previousAttributes()

var attribute = event.split(':')[1];
        event = event.split(':')[0];
        if ((event === 'add' || event === 'remove') && emitter !== this) return;
        if (event === 'destroy') this.remove(model, options);
        if (model && event === 'change' && this._indexes[attribute]) {
            this._deIndex(model.previousAttributes());
            this._index(model);
        }

from ampersand-collection.

wraithgar avatar wraithgar commented on August 24, 2024

this._deIndex(model, attribute, value)

This would require deIndex to be given the index value too, much like it can be given the specific index/

from ampersand-collection.

chabou avatar chabou commented on August 24, 2024

ok but maybe optional parameters. If they aren't passed to the method, we loop on all model attributes. (useful for _addReference)

We could do the same for _index

from ampersand-collection.

chabou avatar chabou commented on August 24, 2024

Can I fill a PR ? Even if you don't accept my changes, I added some useful test cases.

from ampersand-collection.

wraithgar avatar wraithgar commented on August 24, 2024

@chabou this issue is 100% intended for someone who has the time to write up a PR for this THANK YOU SO MUCH if you have the time.

from ampersand-collection.

lukekarrys avatar lukekarrys commented on August 24, 2024

Closed by #47

from ampersand-collection.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.