GithubHelp home page GithubHelp logo

Comments (4)

wraithgar avatar wraithgar commented on July 22, 2024

subcollection is being deprecated, see AmpersandJS/ampersand-subcollection#43

This doesn't change this issue, just where you should be looking as we go forward

filtered-subcollection sortBy line is here https://github.com/AmpersandJS/ampersand-filtered-subcollection/blob/master/ampersand-filtered-subcollection.js#L259

from ampersand-collection.

amoskyler avatar amoskyler commented on July 22, 2024

What are your thoughts for a revision?

Modifying the APIs to both use the same sort function seems to make the most sense, but I could be missing something, in which case documentation clarity would be great.

I can go ahead and make the change and put a PR in whichever way seems to make sense.

from ampersand-collection.

wraithgar avatar wraithgar commented on July 22, 2024

I'd definitely want to hear from other @AmpersandJS/core-team members, but at first glance it seems to me the code in ampersand-collection is a rough version of what's in underscore/amp/lodash sortBy and we should switch to the latter so we are using an abstraction that's being independently maintained and tested.

from ampersand-collection.

amoskyler avatar amoskyler commented on July 22, 2024

Seems to make sense.

from ampersand-collection.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.