GithubHelp home page GithubHelp logo

Comments (4)

cdaringe avatar cdaringe commented on July 20, 2024

interesting. i expected the behavior you expected as well. i'm not sure that this isn't a bug*

from ampersand-events.

wraithgar avatar wraithgar commented on July 20, 2024

onlyOnce makes sense as a name to me, and I wonder if once with multiple names should log a warning. I for one would have fallen into the same assumption. Agreeing w/ @cdaringe that this could even be considered a bug (the fixing of which would probably necessitate a major version however)

from ampersand-events.

dhritzkiv avatar dhritzkiv commented on July 20, 2024

The tests indicate that isn't not a insidious bug in as much as the tests specifically expect the callback to be called for each event name. (https://github.com/AmpersandJS/ampersand-events/blob/master/test/index.js#L528)

The reason for this expectation, I believe, is Backbone's events works this way (I found out through Stackoverflow, where other devs were confused by this behaviour too). Check out this assertion example (using Backbone event instead of ampersand-events) to see for yourselves

from ampersand-events.

dhritzkiv avatar dhritzkiv commented on July 20, 2024

What really confuses me is the expected behaviour after reading through the code logic of ampersand-event's once:

    once: function (name, callback, context) {
        var self = this;
        var once = runOnce(function () {
            self.off(name, once);
            callback.apply(this, arguments);
        });
        once._callback = callback;
        return this.on(name, once, context);
    }

it seems that callback is being wrapped inside a function that also calls off to remove this particular listener for any future events for this name, and then that function is then being wrapped in lodash.once. Not sure if that's right.

from ampersand-events.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.