GithubHelp home page GithubHelp logo

Comments (6)

wraithgar avatar wraithgar commented on July 20, 2024

Do you mean adding methods to sync the api with that of EventEmitter, or extending EventEmitter itself? If it's the former that is being discussed in #13. If it's the latter I don't know if it's a good idea as the browserifying of EventEmitter is quite large and unwieldy, last time I checked.

from ampersand-events.

ianwremmel avatar ianwremmel commented on July 20, 2024

I mostly meant using EventEmitter as a base for ampersand-events. In my experience, EventEmitter is likely to end up in my projects because it's often a dependency of a dependency, so it seemed like a reasonable idea to converge them.

Alternatively, I'd be interested in something like AmpEvents.monkeyPatch(EventEmitter) to bring listenTo and possibly the "all" event to EventEmitter.

All that said, I completely understand if these requests are outside the scope of ampersand, I just wanted to float the idea before attempting to do it.

from ampersand-events.

wraithgar avatar wraithgar commented on July 20, 2024

the API for ampersand-events was definitely a direct result of it being a fork of backbone's event API. I think if we add the methods needed to sync at least the methods with that of node's EventEmitter that will go a long way to reducing the mental effort of trying to work in both worlds, especially in the same project.

Gonna go ahead and close this for now, if someone has any good input on the matter feel free to weigh in or even reopen if you think it's warranted.

from ampersand-events.

ianwremmel avatar ianwremmel commented on July 20, 2024

Follow up question: assuming #14 adds api compatibility with EventEmitter, can/does ampersand-events provide an object that can be used by util.inherits and class X extends EventEmitter as a drop in replacement? I could envision an aggressive webpack config that replaces require('events').EventEmitter with require('ampersand-events').EventEmitter.

from ampersand-events.

wraithgar avatar wraithgar commented on July 20, 2024

Unless I'm mistaken this module itself would be the export. The idea is that require('ampersand-events') would have function parity with require('events').EventEmitter

from ampersand-events.

ianwremmel avatar ianwremmel commented on July 20, 2024

great, I'll give that a try. thanks!

from ampersand-events.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.