amyth / django-instapush Goto Github PK

Hi,

I do not know if this library is still maintained as I see the last commit was three years ago.
Anyway, today I have noticed that in new apns certificates the header
-----BEGIN RSA PRIVATE KEY-----

has been substituted by
-----BEGIN PRIVATE KEY-----

and same for
-----END RSA PRIVATE KEY-----
with
-----END PRIVATE KEY-----

So I suggest to change the method _check_certificate in instapush/libs/apns to include
this changes

def _check_certificate(ss):
    mode = 'start'
    for s in ss.split('\n'):
        if mode == 'start':
            if 'BEGIN RSA PRIVATE KEY' in s or 'BEGIN PRIVATE KEY' in s:
                mode = 'key'
        elif mode == 'key':
            if 'END RSA PRIVATE KEY' in s or 'END PRIVATE KEY' in s:
                mode = 'end'
                break
            elif s.startswith('Proc-Type') and 'ENCRYPTED' in s:
                raise Exception("The certificate private key should not be encrypted")
    if mode != 'end':
        raise Exception("The certificate doesn't contain a private key")

Hope this can help.

Best regards,
Luca

Hi,
I found an issue when sending bulk messages.

In lib/apns.py inside the apns_send_bulk_message function you are cycling over all devices and calling the function _apns_send.

The problem is that _apns_send on line n 123 uses the pop() method to retrieve the notification message:

alert = custom_params.pop('message', '')

and since the message is always stored in the same dictionary, already the second device will receive an empty message.

If you take a look at django-push-notification they simply solved it avoiding the pop method.

Best regards,
Luca

Hi there,

First of all, thank you for your effort to bring Notifications to mongoengine Django projects.
My backend has to support two distinct apps (i.e. client's app and employee's app) and push notifications to both.

Is there a way to register multiple .pem files in order to serve different apps?

Cheers.