analyticspierce / denver-burger-club

Denver-burger-club

This is the repo for the Denver Burger Club site.

denver-burger-club's Issues

update readme with dbc specific info

logo does not show on mobile browser

In chrome on the iphone, the burger club logo does not show up in the nav menu.

airbrake is not configured in prod or staging

2015-03-24T18:13:41.977839+00:00 app[web.1]: ** [Airbrake] Notice was not sent due to configuration:
2015-03-24T18:13:41.810855+00:00 app[web.1]: source=rack-timeout id=948a394d-781d-4368-9b5a-054de3bb1ef7 wait=42ms timeout=10000ms service=3ms state=active
2015-03-24T18:13:41.977846+00:00 app[web.1]: API key set? false

in new review form, score boxes should be limited to numeric values only

the fields to add numeric scores have the entire keypad come up. how can we make this just show the decimal keypad since these are numeric fields. on desktop web, these fields only take numbers.

clean up css for hound feedback

In app/assets/stylesheets/_centered_navigation.css.scss:

• $centered-navigation-item-padding: 1em; > + $centered-navigation-submenu-padding: 1em; > + $centered-navigation-submenu-width: 12em; > + $centered-navigation-item-nudge: 2.2em; > + $horizontal-bar-mode: $large-screen; > + > + background-color: $centered-navigation-background; > + border-bottom: 1px solid darken($centered-navigation-background, 6%); > + min-height: $centered-navigation-height; > + width: 100%; > + z-index: 9999; > + > + // Mobile view > + > + .mobile-logo { > + display: inline;

Rule sets should be ordered as follows: @extends, @includes without @content, properties, @includes with @content, nested rule sets

• &:hover { > + color: $centered-navigation-color-hover; > + } > + } > + > + // Nav menu > + > + .centered-navigation-wrapper { > + @include outer-container; > + @include clearfix; > + position: relative; > + z-index: 999; > + } > + > + ul.centered-navigation-menu { > + -webkit-transform-style: preserve-3d; // stop webkit flicker

Rule sets should be ordered as follows: @extends, @includes without @content, properties, @includes with @content, nested rule sets
Properties should be ordered clear, display, margin, overflow, padding, -webkit-transform-style, width, z-index
Avoid vendor prefixes.

• a { > + margin-right: $centered-navigation-submenu-padding; > + } > + > + > a { > + padding-right: 0.6em; > + } > + > + > a:after { > + @include position(absolute, auto -0.4em auto auto); > + color: $centered-navigation-color; > + content: "\25BE"; > + } > + } > + > + li.more {

Merge rule li.more with rule on line 156
Avoid qualifying class selectors with an element.

In app/assets/stylesheets/_centered_navigation.css.scss:

• &:focus, > + &:hover { > + color: $centered-navigation-color-hover; > + } > + } > + > + // Nav menu > + > + .centered-navigation-wrapper { > + @include outer-container; > + @include clearfix; > + position: relative; > + z-index: 999; > + } > + > + ul.centered-navigation-menu {

Avoid qualifying class selectors with an element.

• • @include media ($horizontal-bar-mode) { > + display: block; > + text-align: center; > + } > + } > + > + // The nav items > + > + .nav-link:first-child { > + @include media($horizontal-bar-mode) { > + margin-left: $centered-navigation-item-nudge; > + } > + } > + > + ul li.nav-link {

Avoid qualifying class selectors with an element.
Selector should have depth of applicability no greater than 2, but was 3

• line-height: 0; > + > + @include media($large-screen) { > + display: inline; > + } > + } > + > + .logo img { > + margin-bottom: -$centered-navigation-logo-height / 3; > + max-height: $centered-navigation-logo-height; > + opacity: 0.6; > + } > + > + // Sub menus > + > + li.more.nav-link {

Avoid qualifying class selectors with an element.

• color: $centered-navigation-color-hover; > + } > + } > + > + @include media($horizontal-bar-mode) { > + background: transparent; > + display: inline; > + line-height: $centered-navigation-height; > + > + a { > + padding-right: $centered-navigation-item-padding; > + } > + } > + } > + > + li.logo.nav-link {

Avoid qualifying class selectors with an element.

• @include media ($horizontal-bar-mode) { > + display: block; > + text-align: center; > + } > + } > + > + // The nav items > + > + .nav-link:first-child { > + @include media($horizontal-bar-mode) { > + margin-left: $centered-navigation-item-nudge; > + } > + } > + > + ul li.nav-link { > + background: $centered-navigation-background;

Rule sets should be ordered as follows: @extends, @includes without @content, properties, @includes with @content, nested rule sets

• right: $centered-navigation-submenu-padding / 2; > + } > + } > + > + &:focus > .submenu, > + &:hover > .submenu { > + display: block; > + } > + > + @include media($horizontal-bar-mode) { > + padding-right: $centered-navigation-submenu-padding; > + position: relative; > + } > + } > + > + ul.submenu {

Avoid qualifying class selectors with an element.

• margin-right: $centered-navigation-submenu-padding; > + } > + > + > a { > + padding-right: 0.6em; > + } > + > + > a:after { > + @include position(absolute, auto -0.4em auto auto); > + color: $centered-navigation-color; > + content: "\25BE"; > + } > + } > + > + li.more { > + overflow: visible;

Rule sets should be ordered as follows: @extends, @includes without @content, properties, @includes with @content, nested rule sets

add feature specs

Pending:
Judge add some examples to (or delete) /Users/pierce/Documents/MSD/projects/msd/denver-burger-club/spec/models/judge_spec.rb
# Not yet implemented
# ./spec/models/judge_spec.rb:4
Restaurant add some examples to (or delete) /Users/pierce/Documents/MSD/projects/msd/denver-burger-club/spec/models/restaurant_spec.rb
# Not yet implemented
# ./spec/models/restaurant_spec.rb:4
Review add some examples to (or delete) /Users/pierce/Documents/MSD/projects/msd/denver-burger-club/spec/models/review_spec.rb
# Not yet implemented
# ./spec/models/review_spec.rb:4

in new review form, comment box should be bigger

judges should be able to write a comment and see the whole comment in the box

add Phil as a judge

also update the score submitted by Ryan to be submitted by Phil

need to add production data

restaurants, judges, and existing reviews need to be added to production

setup Code Climate test coverage reporter

Instructions here:

https://codeclimate.com/repos/54ded9886956806ffe009f40/coverage_setup

Ruby instructions

Add the codeclimate-test-reporter gem to your Gemfile:

gem "codeclimate-test-reporter", group: :test, require: nil

Start the test reporter on the very first line of spec_helper.rb or test_helper.rb:

require "codeclimate-test-reporter"
CodeClimate::TestReporter.start

When you run your tests on CI, set the CODECLIMATE_REPO_TOKEN environment variable:

$ CODECLIMATE_REPO_TOKEN=062cf0f713ab64981847dc43e9eb02dbe581fe1f783c7b1acb0087fa18942631 bundle exec rake