andau / abapci Goto Github PK

Running ATC check or unit tests for a package seems to be a synchronous process which will make the whole IDE freeze until the checks are done.

Hi,

when installing the plugin, I get the error

Software currently installed: ABAP Continuous Integration 0.5.5.2 (com.abapci.feature.feature.group 0.5.5.2)
Missing requirement: com.abapci.plugin 0.5.5.2 requires 'osgi.bundle; org.junit.platform.commons 0.0.0' but it could not be found
Cannot satisfy dependency:
From: ABAP Continuous Integration 0.5.5.2 (com.abapci.feature.feature.group 0.5.5.2)
To: org.eclipse.equinox.p2.iu; com.abapci.plugin [0.5.5.2,0.5.5.2]

is there something wrong with my installation or the plugin?

Sometimes things can be slow and It would be nice to have some feedback on whether something's going on. Currently there's only the 'Last Run' column.

Hi Andau,

great plugin, I think it is solving a major gap in the SAP development workflow, that is the automatic ATC run directly upon activation of source code.
It is running fine, but what I don't understand is how I should evaluate the results.
If I run ATC manually from Eclipse. I get a nice result list in the 'ATC problems' view. Event better, in my editor, all the findings are highlighted.
If I don't run the ATC manually, but activate only, AbapCI starts running and executes the ATC (perfect!). But then I only get the message 'ATC errors' in the status bar, but the errors are not shown in the 'ATC problems' view nor are they shown in the editor.

Do I miss out something?
How can I easily see all the errors from the current automatic ATC run, so I can start working on them?

Would be great if you come back to me although I see that this repo seems not to be under maintenance anymore.

Gruß,
Sebastian

Hello,

it would be great to have some formatter/beautifier that could enforce custom rules to solve formatting discrepancies in team (like indentation of IF's, method calls etc.) ?
Or are you aware about such tool?

#autoformat is nice, but Pretty Print is unfortunately not so powerful...

Feel free to close this as it not real issue :)

Hello Andreas,
it would be helpful if we could define in the settings of ABAP CI, until wich levels of:

• Surverity ( medium; critical, ....) and Timing we wand unit tests to be executes automatically

Thanks for good work so far
Timo

Hi,

(1) You really made great progress in the last months - really good work & thanks a lot!
(2) Have you been in contact with anyone from SAP (e.g. Thomas Fielder?) to open up the API of com.sap.adt.atc.ui? While for me the current implementation is fine, it is really a little bit annoying in case upgrades are on the way :-)
(3) Do you see a simple chance to implement, that also ATC-Warnings (prio 2) are failing a build? It would be possible to configure the whole sci variant to have errors only - still I want that the devlopers can distinguish between critical and not so critical errors - while they are not allowed to keep one of them in the code..

Thanks again,
Timo

Hi,

After installing the plugin and activating quite a lot of objects, I get into the situation, that the plugin is pushing 1 request per second (see log)

That will fill up the system.. Do you have any idea, what is going on here?

Greets,
Timo

It would be nice to bind a shortcut to the abapGit action. I think this was possible in earlier versions

It would be very nice if we could start abapGit from any editor (with an development object assigned to a package) and via the quick access menu. If I try to start abapGit via quick access currently the following message appears.

I set the "Show this dialog again..." option in this dialog, but it is popping up again for new packages.

Hi @andau,

I installed the source-code of the plugin now and was also easily able to get it running in debug mode - thanks for that.
Quick Question: Ideally I'd like to trigger a single ATC check (like when pressing CTRL+SHIFT+F2) when activating, and actually trigger an ATC check. Have you tried that before?
I assume that the corresponding API is within com.sap.adt.atc.ui.internal.launch package. I am not really able though to communicate with objects in that package (or find the correct API) - anyways I am also not the biggest java developer.. So have you tried that before, and have any hints?
Pull request with corresponding option in the settings would follow ofc..

Greets,
Timo

when installing plugin into an eclipse 2022-09 an installation error shows up:
Error message:
Cannot complete the install because one or more required items could not be found.
Software currently installed: ABAP Continuous Integration 0.5.5.2 (com.abapci.feature.feature.group 0.5.5.2)
Missing requirement: com.abapci.plugin 0.5.5.2 requires 'osgi.bundle; org.junit.platform.commons 0.0.0' but it could not be found
Cannot satisfy dependency:
From: ABAP Continuous Integration 0.5.5.2 (com.abapci.feature.feature.group 0.5.5.2)
To: org.eclipse.equinox.p2.iu; com.abapci.plugin [0.5.5.2,0.5.5.2]

Hi,

auto-format work incorrect for simple transformations - it aligns everything to the left and adds an additional "!" to a comment:
<!-- becomes <!!--

BR,
Jacek

The autoformat does not work for ABAP CDS Views.

Currently when we call abapGit in the context menu of a package abapGit is opened with home screen and no repo is opened.

It would be nice if we could open the repo corresponding to the selected package automatically. Technically we can solve this with a GET/SET parameter (which doesn't exist yet in abapGit but would be easy to implement). Is it possible to supply GET/SET parameters from ADT when calling a transaction? If yes we can do this.

I have auto-format switched on but it is not working. The code is not auto-formatted when I save or generate an ABAP program. I have version 0.55 of the plugin installed with Eclipse Oxygen 3a Release 4.7.3a.

In an older version of the plugin whenever I started Eclipse I had to go the preferences pane and switch the auto-format off and then on again to get it to work. Now it has stopped working altogether.

A known reason for this to happen is, if there still exists an old xml configuration file from the first version of this feature. If this happens the first time please delete or rename the file coloredProjectModel.xml on your file system and reopen the view.

The file is not related to something else than the ABAP CI plugin and contains only information about the coloring of projects.

The file should be located in $ECLIPSE_WORKSPACE.metadata.plugins\com.abapci.core\coloredProjectModel.xml

I am trying the following steps. Please guide me where I am going wrong.

Installed eclipse then ABAP CI plug in. I have a class with unit test class. When I am executing abap unit test it is showing the exception. But I have configured my package for auto trigger of unti test after activation. But it is not working.

Please find the attachment.
ABAP CI.docx

These fields are unnecessarily short:

Is it possible to make the color apply to all parts of the status bar?

Hello Andreas,
for my understanding it does not make sense in ABAP to run the unit test after SAVE as it would use the old load of code.
=> Pls Change to "after Activation"

I am unable to install Abap Continuous Integration add-on in my eclipse. I have installed Eclipse Java Development Tools as well.

Eclipse IDE for Java Developers (includes Incubating components)
Version: 2023-03 (4.27.0)
Build id: 20230309-1520

I am getting the below error.

Cannot complete the install because one or more required items could not be found.
Software currently installed: ABAP Continuous Integration 0.5.5.2 (com.abapci.feature.feature.group 0.5.5.2)
Missing requirement: com.abapci.plugin 0.5.5.2 requires 'osgi.bundle; org.junit.platform.commons 0.0.0' but it could not be found
Cannot satisfy dependency:
From: ABAP Continuous Integration 0.5.5.2 (com.abapci.feature.feature.group 0.5.5.2)
To: org.eclipse.equinox.p2.iu; com.abapci.plugin [0.5.5.2,0.5.5.2]

Hi,

Opening a Project in HANA Repository perspective (HANA Developer), leads to the coloring question.
Would be good, if ABAPCi is only reacting on ABAP projects.

Thanks,
Timo

Hi,

After installing the plugin and activating quite a lot of objects, I get into the situation, that the plugin is pushing 1 request per second (see log)

That will fill up the system.. Do you have any idea, what is going on here?

Greets,
Timo

I'm running into the following error when updating:

Cannot complete the install because one or more required items could not be found.
Software currently installed: ABAP Continuous Integration 0.5.4.2 (com.abapci.feature.feature.group 0.5.4.2)
Missing requirement: com.abapci.plugin 0.5.4.2 requires 'osgi.bundle; org.junit.jupiter.api 0.0.0' but it could not be found
Cannot satisfy dependency:
From: ABAP Continuous Integration 0.5.4.2 (com.abapci.feature.feature.group 0.5.4.2)
To: org.eclipse.equinox.p2.iu; com.abapci.plugin [0.5.4.2,0.5.4.2]

Dear Andau,

First thanks for your work in that open source plugin.
We are currently evaluating the use of it. Most probably we will need a few extensions (e.g. hierarchical control for packages, as mentioned in issue 5, or also better control of ATC Runs).

Of course I'd like to make a normal pull request for that - I am however not really sure if I am allowed to do so, due to the missing license.
Can you please clarify the license and add it to the git repository?

Thanks,
Timo

Cannot install abapCI 0.5.5.2 on Eclipse Java 2023-12 (4.30.0) with ADT 3.40 from the https://tools.hana.ondemand.com/latest

Cannot complete the install because of a conflicting dependency.
Software being installed: ABAP Core Development Tools 3.40.0 (com.sap.adt.core.feature.group 3.40.0)
Software currently installed: ABAP Continuous Integration 0.5.5.2 (com.abapci.feature.feature.group 0.5.5.2)
Only one of the following can be installed at once:
ABAP Source Code Support 3.38.2 (com.sap.adt.tools.abapsource 3.38.2)
ABAP Source Code Support 3.40.0 (com.sap.adt.tools.abapsource 3.40.0)
Cannot satisfy dependency:
From: ABAP Continuous Integration 0.5.5.2 (com.abapci.feature.feature.group 0.5.5.2)
To: org.eclipse.equinox.p2.iu; com.abapci.plugin [0.5.5.2,0.5.5.2]
Cannot satisfy dependency:
From: com.abapci.plugin 0.5.5.2
To: java.package; com.sap.adt.tools.abapsource.abapunit 0.0.0
Cannot satisfy dependency:
From: ABAP Core Development Tools 3.40.0 (com.sap.adt.core.feature.group 3.40.0)
To: org.eclipse.equinox.p2.iu; com.sap.adt.tools.feature.group [3.40.0,3.40.0]
Cannot satisfy dependency:
From: ABAP Development Tools Foundation 3.40.0 (com.sap.adt.tools.feature.group 3.40.0)
To: org.eclipse.equinox.p2.iu; com.sap.adt.tools.abapsource [3.40.0,3.40.0]

As a workaround using ADT 3.38; can be downloaded from SAP Download Centre https://me.sap.com/notes/3391753/E

org.junit.platform.commons 0.0.0 issue fixed with solutions from #34

ADT 3.38 dependencies:-
EMF Workspace
http://download.eclipse.org/modeling/emf/transaction/updates/releases/R202208110935
EMF Data Binding
https://download.eclipse.org/modeling/emf/emf/builds/release/latest
EMF Validation
http://download.eclipse.org/modeling/emf/validation/updates/releases
EMF Query
http://download.eclipse.org/modeling/emf/query/updates/releases
Graphiti
http://download.eclipse.org/releases/2023-12
org.junit.platform.commons and others from #34
https://download.eclipse.org/tools/orbit/downloads/drops/R20230302014618/repository

Is there a possiblity to use Colored Projects with Default Dark Theme?

When I activate Option to color Rulers, it does not show up, unfortuantely it works in Classic Theme.

Another question:
Why is it not possible anymore to configure your own colors? IMHO this was a major advantage of the Plugin.

first of all, a very nice idea.
we need more of this in abap :-)

Issue:
If you switch off abapCi in settings, abapCI seems still to process something.
At least it keeps appearing in the right corner of IDE every 3 seconds

Hi,

What Happens: ATC checks are only executed once, and afterwards in endless loading state
Expected: Activation always leads to a re-evaluation of ATC checks

I am using Eclipse Oxygen.3a (4.7.3a) with ABAP Plugin Version 2.102.6. Is that identical to the version you are using?

Steps to reproduce
Create report with clear ATC error in it --> activate

--> Error is reported

--> Comment the line

--> Activate again --> Error is still there: AbapCI is claimed to be always "active"

Preferences:

Thanks,
Timo

After upgrading from Eclipse 2021-12 to 2022-03 I get a pop-up message after activating a development object; The pop-up states:

'AbapCI Active' has encountered a problem.

An internal error occurred during: "AbapCI active' (see picture below).

ABAP CI Plugin settings:

So far, I tried to (de)activate some of the settings above, but the (error) message persists.

BTW: The development object is activated despite this message.

P.S. I also asked the same question on scn.sap.com (19 views so far, but no answer).
https://answers.sap.com/questions/13613563/eclipse-2022-03-abapci-active-has-encountered-a-pr.html

Would be helpful to have a installation possibility for this plugin like it is available here:
https://github.com/cucumber/cucumber-eclipse/wiki/Download-and-Install-Plugin-From-Zip

In situations where your are at your client and are not allowed to connect your eclipse to eclipse marketplace, but you have the possibility to use a browser for surfing.

I'm currently in such a situation :-(

What do you think?

Hi,

I am getting error while trying to install the Plugin through Eclipse Marketplace. Please see attached screenshot.

The repository site mentioned in the screenshot does not exist!

Hi guys,

On macos icons added by plugin to toolbar are too big. This cause that toolbar is few times bigger as usual. Check out screenshot.

Currently the Unit Testrun is only executed for the package the ABAP development object is assigned. Also a triggered Unit Testrun of an eventually parent package is desirable.

Example
MainPackage
-> Subpackage
-> Development object (class_of_subpackage.class)
-> Development object (class_of_mainpackage.class)

Everythink works perfect if only the Subpackage(s) is (are) added to the Unit testrun.

If the MainPackage is added to the Unit testrun too, an eventual error in the Development object of the class_of_subpackage.class is counted twice and stays in the mainpackage when fixed in the subpackage as only the Unit Testrun of the subpackage is triggered.

Therefore an option would be to only include the main package and get the Unit Testrun for the MainPackage executed when a development object of this package or a subpackage is activated. But as the MainPackage is currently not triggered thats not an option.

Current code in SapConnection.java:
IInactiveCtsObject ctsObject = ...
IAdtObjectReference ref = ctsObject.getObject().getRef();
String packageName = ref.getPackageName()
// --> TODO how to get an eventually existing parent package of the packageName