GithubHelp home page GithubHelp logo

seo-meta-field-nova's People

Contributors

andreasgj avatar marcorivm avatar semsphy avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

seo-meta-field-nova's Issues

Missing Package License

Hi,

We've created a fork of this package to make some changes in order to support SEO translations, but we've noticed this package is missing a license, please add one.

Thank you

Output is the default from .env only

I have made all the setup and the data is even saved.. but when trying to load the information with @include('seo-meta::seo') just the default ones from the .env shows.

Tag "lastmod" does not meet WC3 standards which leads to a wrong sitemap structure!

Hi,

I found your awesome package on GitHub and was very happy to have a package which takes core of the sitemap.

However, there is one problem. The sitemap the package generates does not meet the WC3 and google supported date time format.

You print the normal Laravel ‚updated_at‘ format like "2020-10-10 12:34:12“ for the tag lastmod. But this is not correct. According to this article the date format needs to be "YYYY-MM-DD" or Datetime which would be "YYYY-MM-DDThh:mm: ssTZD“.

Could you guys please update that as soon as possible?
I really would appreciate that a lot!

Thanks!

Nova 4 compatibility

  • Upgrade to vue 3
  • Remove laravel-nova front end dependecy
  • Include nova 4 dependecies

I'll submit a PR that addresses this in a bit.

subscribe @AndreasGJ

SEO feature does not work on create page laravel nova

  • Laravel Version: v8.83.10
  • Nova Version: 3.32.0
  • PHP Version: PHP 7.4
  • Browser type and version: Chrome 100.0

I am trying to show the SEO feature on the create page so that I can create the SEO feature then I can edit it,
but when I put some data and click save, no data is saved in the seo_meta table
and it comes back empty, but the feature works fine in updating the page.
this is my code SeoMeta::make('SEO', 'seo_meta') ->disk('s3') ->showOnCreating(),

Laravel morphMap not working

If Relation::morphMap is set in the AppServiceProvider, then the entry with the polymorphic relationship is created by the fully qualified class name.
After creating a seo record, the fields in the form are not filled.

Field doesn't work or installation instructions are incomplete

Hi, I tried using this field on my project, but it simply doesn't work. I followed installation instructions to the detail, rechecked if I missed anything several times, and still it won't work. Existing database records show "SEO" column in index, but its value is empty empty (no red/green circle). New database records cannot be saved at all: dev tools shows TypeError: "e.t0.response is undefined" when I try to save them. Furthermore, SEO field isn't visible on edit form at all. My eloquent model looks like this:
`
class FaqCategory extends Model
{
use SoftDeletes;
use SeoMetaTrait;

protected $table = 'faq_category';

protected $fillable = [
    'creator_id',
    'title',
    'ordering',
    'published',
];

public static function orderColumnName(): string
{
    return 'ordering';
}

public function creator()
{
    return $this->belongsTo(User::class, 'creator_id');
}

public function initOrdering(): void
{
    $this->ordering = (int) self::max(self::orderColumnName()) + 1;
}

}
`

I'm setting creator_id and calling initOrdering in an observer, during creating event.

Missing validation rules for fields length

Just ran into this issue while trying to insert some date using the nova field
SQLSTATE[22001]: String data, right truncated: 1406 Data too long for column 'description'
It would be a good idea to set some validations rules so the users don't try to insert data that is too long, as it will only fail saying server error.

Deprecation notices on installation

Laravel 7
Nova 3

On installation, presented with many notices from Composer

Deprecation Notice: Class Gwd\SeoMeta\Traits\SeoSitemapTrait located in ./vendor/gwd/seo-meta-nova-field/src/traits/SeoSitemapTrait.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185
Deprecation Notice: Class Gwd\SeoMeta\Traits\SeoMetaTrait located in ./vendor/gwd/seo-meta-nova-field/src/traits/SeoMetaTrait.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185
Deprecation Notice: Class Gwd\SeoMeta\Models\SeoMetaItem located in ./vendor/gwd/seo-meta-nova-field/src/models/SeoMetaItem.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185
Deprecation Notice: Class Gwd\SeoMeta\Helper\SeoSitemap located in ./vendor/gwd/seo-meta-nova-field/src/helper/SeoSitemap.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185
Deprecation Notice: Class Gwd\SeoMeta\Helper\Seo located in ./vendor/gwd/seo-meta-nova-field/src/helper/Seo.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185

Package not found

If I try to install your package with composer I get the following error:
[InvalidArgumentException] Could not find a matching version of package agj/seo-meta-field-nova. Check the package spelling, your version constraint and that the package is avai lable in a stability which matches your minimum-stability (dev).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.