Grand Strategy crash on Linux about wyrmsun

[akien-mga]

Unrelated: You should try to use the ``` tags before pasting a backtrace, else the numbered references are interpreted as issue numbers, and you get cross-referencing like in all issues up to issue 11 currently: "Andrettin referenced this issue 5 days ago" (see the GitHub doc about Markdown formatting for details)

[akien-mga]

I could not reproduce the crash here with v1.3.1 on 64bit. I'll keep an eye out for such issues though.

[Andrettin]

Ops, I forgot to put the code tags, thanks for the heads up! Thanks for testing; I'll close this issue then since it could not be reproduced with version 1.3.1 (if someone reports it again I'll reopen it).

[akien-mga]

Actually I get this issue now, still with v1.3.1 (from Steam). The game freezes, with the music still playing to the end, and only this output in the terminal:

realloc(): invalid next size: 0x0000000006740ca0

[akien-mga]

I see you've investigated some minor lua issues in the grand strategy code lately, I'll check if it works better with the master branch.

[akien-mga]

I tried building the master branch on Mageia 5 and I get the same issue. The good news is that it's therefore not linked to the fact that we link Ubuntu 12.04's lua5.1 lib into the binary, as the binary I just compiled on Mageia uses the system-wide version of lua5.1 dynamically.

[akien-mga]

When I run the binary through gdb, I can't reproduce the issue anymore :-/

[Andrettin]

Based on some tests the user who reported this issue did, it seems that the error is due to the size of the argument for the SetWorldMapTerrain function in the world map definitions. As a fix to this issue, I changed the world maps to use the SetWorldMapTileTerrain for each tile now in c531bd6

The issue thus should be solved, but let me know if it persists :)

[akien-mga]

Ah indeed I can imagine that the argument was a bit heavy for lua. It's the kind of long stuff security researchers use to try to find vulnerabilities :-P

[akien-mga]

I confirm that it fixes the issue, well done :)

[Andrettin]

Nice :)