Comments (6)
I'm rephrasing this ticket as there could be some problems when creating non-standard heroes. Let's say I want to create a hero with name ../Modsognir, it will rewrite an existing Modsognir hero.
Luckily it's not possible to rewrite savegames as delimiters like \n doesn't seem to work in user input.
Another thing is that when you create an inappropriate hero with name e.g. //\yCoolHero, its' profile won't be created and it will be accessible only during this launch.
from wyrmsun.
You are right, those are serious concerns. Thanks for bringing this up!
I've fixed the issue now, and also made the check which sees whether another hero of the same name exists case-insensitive (since Windows cannot have two files with the same name even if they are written with letters in different cases).
I've also added a check to see if the name has only spaces in it.
7e7a515
0cdabf5
Andrettin/Wyrmgus@b340336
from wyrmsun.
Is it ok that hero can have empty name with space in it and valid surname? Usually name is required, surname is optional. Other cases seem to be covered now.
from wyrmsun.
Now that you mention it, that shouldn't be possible, thanks for letting me know. I've fixed it now:
Andrettin/Wyrmgus@7b2d306
from wyrmsun.
Well, I'm still not satisfied. ;)
If I try to create any hero I don't get anything except "error in error handling" in terminal.
from wyrmsun.
Ops, I forgot to upload the corresponding Wyrmsun repository commit:
65aa3d3
from wyrmsun.
Related Issues (20)
- Unused/phased out Wyrmsun assets? HOT 4
- Inexhaustible rock deposits? HOT 1
- Cannot select anything on the map after winning singleplayer scenario HOT 4
- Music sometimes stutters during play HOT 3
- Selectable item groups in map editor? HOT 2
- [5.3.3] Dungeon door glitches HOT 7
- Ally AI inactive in The Battle of Magetobria?
- [5.3.4] Menu (F10) becomes not accessible in the editor HOT 2
- [5.3.4] Screen capture duplicates the first screenshot HOT 3
- Possibly useful public domain sound effects from OGA HOT 2
- Clutter of similar type objects in random maps HOT 9
- [5.3.4] Heroes healed to full health when loading a saved game HOT 1
- [5.3.4] The First Dwarves generates underground as part of the overworld HOT 3
- [5.3.4] Skirmish AI has trouble locating far ore mines HOT 2
- [5.3.4] Goblin Mason's Shop uses the wrong frame for incomplete construction HOT 1
- Units level up too slowly HOT 3
- crash Artix latest HOT 5
- Faction Differentiation Improvements
- Compiling Older Versions of Wyrmsun
- Can Affixes work as Conditions for Item Variations? Edit: Now they will HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wyrmsun.