GithubHelp home page GithubHelp logo

Comments (6)

KroArtem avatar KroArtem commented on July 28, 2024

I'm rephrasing this ticket as there could be some problems when creating non-standard heroes. Let's say I want to create a hero with name ../Modsognir, it will rewrite an existing Modsognir hero.

Luckily it's not possible to rewrite savegames as delimiters like \n doesn't seem to work in user input.

Another thing is that when you create an inappropriate hero with name e.g. //\yCoolHero, its' profile won't be created and it will be accessible only during this launch.

from wyrmsun.

Andrettin avatar Andrettin commented on July 28, 2024

You are right, those are serious concerns. Thanks for bringing this up!

I've fixed the issue now, and also made the check which sees whether another hero of the same name exists case-insensitive (since Windows cannot have two files with the same name even if they are written with letters in different cases).

I've also added a check to see if the name has only spaces in it.

7e7a515
0cdabf5
Andrettin/Wyrmgus@b340336

from wyrmsun.

KroArtem avatar KroArtem commented on July 28, 2024

Is it ok that hero can have empty name with space in it and valid surname? Usually name is required, surname is optional. Other cases seem to be covered now.

from wyrmsun.

Andrettin avatar Andrettin commented on July 28, 2024

Now that you mention it, that shouldn't be possible, thanks for letting me know. I've fixed it now:
Andrettin/Wyrmgus@7b2d306

from wyrmsun.

KroArtem avatar KroArtem commented on July 28, 2024

Well, I'm still not satisfied. ;)
If I try to create any hero I don't get anything except "error in error handling" in terminal.

from wyrmsun.

Andrettin avatar Andrettin commented on July 28, 2024

Ops, I forgot to upload the corresponding Wyrmsun repository commit:
65aa3d3

from wyrmsun.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.