GithubHelp home page GithubHelp logo

andrew6rant / auto-slabs Goto Github PK

View Code? Open in Web Editor NEW
23.0 23.0 4.0 265 KB

Inject blockstates at runtime to automatically generate vertical slabs for every instance of SlabBlock

License: MIT License

Java 100.00%
minecraft

auto-slabs's Introduction

auto-slabs's People

Contributors

akashiikun avatar altirix avatar andrew6rant avatar dadoirie avatar superkat32 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

auto-slabs's Issues

[Mod Support Request] Create slab's vertical texture

Hi, love the mod and how well it works with all slabs. Some slabs have a "oriented" texture similar to the vanilla Smooth Stone Slab.

In particular the create mod provides a lot of cut variants which look a bit weird when placed vertically:

2023-10-25_23 06 37

Would be awesome if you could somehow have them look the same to the horizontal slabs

1.19.2 Branch?

I saw your mod on Modrinth and came to the source just to check, and I noticed there's a 1.19.2 branch. As a 1.19.2 player, are there any plans to backport/maintain that branch? I've got no idea how much work it would be, but I saw the branch and was curious.

Texture bug when placing Terraqueous slabs vertically.

I'm not sure if this is the same issue as the one in #13 , but I had mentioned this in that thread and I'm just reposting it here to make it easier to find. I noticed that when I put down slabs of materials from Terraqueous vertically individually, the textures don't display (though if I put two of them vertically side-by-side the textures pop in as if they were horizontal slabs).

Also, you might need to install Every Compat to get the slabs from Terraqueous because I don't remember if it natively has them.

Slabs new hitboxes for placement cause some blocks to go invisible and some be placed wrong/oddly

image
image
As seen in the first screenshot, the mod made the slabs place weird and that made the connecting block go invisible/transparent.
and in the second it shows how the hitbox is weird/off and it ended up placed weird.
I enjoy the aspect of the mod for more customization but i'm just trying to build a floor out of wood slabs in Medieval Minecraft 1.20.1 Fabric, and its made it more complicated when it's not needed. It would be much better if you could toggle the advanced placement hitboxes while in game with a keybind of some sort or something.

Missing textures for BetterEnd/BetterNether slabs

We briefly discussed this on Discord, just submitting an issue for tracking.

Better-End-2.1.6
Better-Nether-7.1.4
AutoSlabs-1.1.0

Place any BCLib slab vertically and the texture will be missing.

Better Nether/Better End Slabs Appear Untextured

Better Nether slabs only render properly when horizontal, or as a double slab of any type. Better End slabs never render properly, additionally appearing as a whole untextured block even when as a single horizontal slab.
2024-04-07_12 16 08
2024-04-07_12 16 43

incompatibility with Snow! Real Magic

the Snow! Real Magic mod has an interesting feature, when you place a slab where there was a layer of snow, that slab will have snow on top, but when using the AutoSlab mod, the slab becomes invisible

2023-11-06_21 31 05

the same does not happen if you place a slab where there is no snow and then put snow on top of the slab, it works correctly that way

2023-11-06_21 36 05

*im using fabric 1.20.1

Feature Request: A Temporarily Disable Option

Hopes to add an option or a switch to disable the complex placements of slabs temporarily. This is useful when I need to build mob farms that need lots of slabs, and I need to place them quickly.

Glass panes not connecting to vertical slabs

actual behavior
image

expected behavior
image

if need idea/inspiration how to accomplish that check the enchanted vertical slabs mod (uses only vanilla slabs and they also need to be crafted)
your approach is much better as slabs are slabs and they should be able to be place horizontally & vertically (without the need to "craft" vertical slabs)

besides that slabs from other mods are not being placed vertically - they are being placed on the lower or higher half of the full block depending on which side being placed, because the overlay on the placed block from auto-slab is present

extra: please make vertical glass slabs work, as all the dynamical vertical slabs mod haven't managed that - they ain't transparent & a middle line is present like the slab is cut in 2

[REQUEST] Different blocks at the same tile

I loved the mod so far and I thought that would be cool for many builds if the mod would let me place different blocks (verticals too) together.

Ex.: If I'm building a house, and I want the external wall to be cobblestone but the interior wall to be wood

Placeholder Texture Appears in some modded slabs

Many Slabs from mods have the missing texture problem, to recreate this issue is just a matter of installing different mods that add slabs.
So far I've seen this in Chipped, Immersive Weathering, and the slabs generated by Every Compat.
I haven't texted every mod I have, but the issue is likely to appear in others, please look into this.

Slabs from other mods are not being placed vertically

As the title says, slabs from other mods are not being placed vertically despite those having the placement overlay which auto slabs provides.
Yesterday tried with Consistency+ and for faster loading now a own instance with 2 smaller mods which provide slabs.
image
image

Removing mod causes world to corrupt.

I was playing (on a server) with this mod. The hardware isn't that great and the mod was kinda laggy so I removed it. Upon relaunching, lots of different blocks were replaced with other random blocks. Tall grass became double dark prismarine slabs, bamboo became shulker boxes etc. This really needs to be reworked, if possible, especially because I would still like to remove this mod from my server without having to reset the world.

Sneaking While Mining Single Slabs Causes Duplication

If you sneak while mining a single slab, it drops 2 slabs instead of one. Seems to happen for all types of slabs(wooden, stone, etc.), but I haven't tested with modded slabs.

Minecraft Version: 1.20.1
AutoSlabs Version: 1.0.1

Video:

slabs.mp4

Other mods present in the video were Mod Menu and Fabric API.

Currently working on a PR to fix if you haven't fixed it locally already.

Slabs do not synchronize on an Essential multiplayer server, 1.20.1

Was testing this with a friend on an Essential multiplayer server, and when the slabs are placed, it is not synchronized between the two of us which results in things looking different and collision issues. When mine was flush against a wall, his was rotated to the right side of the block. This was a Bewitchment modded block in particular but since this is supposed to work with all slab variants I don't imagine that would be the reasoning. This happens no matter which one of us placed the block, either him (the host), or me.

Placing sound is played even when no slab is placed

I've noticed that when trying to place slabs somewhere they can't be placed (e.g. right inside the player's hitbox) the sound of placing a block is played. Although correctly no block is placed, both the animation (player's hand swinging) and the sound are triggered. It's just a minor inconvenience, but it can be irritating at times ^^
Besides that I've been enjoying this mod quite much!

[1.20.1] Crash on startup

java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'autoslabs'!
at net.fabricmc.loader.impl.FabricLoaderImpl.lambda$invokeEntrypoints$2(FabricLoaderImpl.java:387)
at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
at net.fabricmc.loader.impl.FabricLoaderImpl.invokeEntrypoints(FabricLoaderImpl.java:385)
at net.fabricmc.loader.impl.game.minecraft.Hooks.startClient(Hooks.java:52)
at net.minecraft.class_310.(class_310.java:458)
at net.minecraft.client.main.Main.main(Main.java:211)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:243)
at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:278)
at org.multimc.EntryPoint.listen(EntryPoint.java:143)
at org.multimc.EntryPoint.main(EntryPoint.java:34)
Caused by: java.lang.NoSuchFieldError: BETWEEN_MODS_AND_USER
at io.github.andrew6rant.autoslabs.AutoSlabs.onInitialize(AutoSlabs.java:30)
at net.fabricmc.loader.impl.FabricLoaderImpl.invokeEntrypoints(FabricLoaderImpl.java:383)
... 14 more

[Fabric] [1.20.1] Slab Placemetn line vanish afterusing off hand item

When right clicking to use the off-hand item, whether you are holding a slab or not, (Shield, food, torches, etc.) this will break the auto-slab outline. It will revert back to the default block outline, but auto slab is still functional. This issue persists until you either change dimensions or relog.

Vanilla slabs never appear vertical

When I first installed this mod, everything worked fine, but there were eventually missing textures on slabs from the mod Better End, so I installed the compat resource pack for this mod to fix the missing textures. I can't really say for sure that the resource pack is at fault, but after installing it, every vanilla slab's vertical textures doesn't work. I can place them vertically but they don't appear vertical, like this image from another closed ticket:

image

I've tried uninstalling and reinstalling with or without the resource pack and it still won't work. Also, this problem is only for vanilla slabs, modded slabs work just fine.

Is there a specific way to rearrange resource packs that should fix this issue? If not, are there any logs that should be useful for this issue? After a quick look through the files, I didn't find anything that seemed related to the problem.

Windowlogging-type functionality?

Windowlogging is a Forge mod that allows you to place glass panes (and presumably bars but I haven't tested them) inside slabs and stairs; it would be cool to see that functionality either in this mod or an add-on.

Keybind toggle to enable/disable autoslab mod

Would it be possible to implement a keybind so you can toggle the autoslab placement? When building large areas (roofs/floors) it can be quite frustrating as it is very easy to misplace a slab. A toggle for this would be greatly appreciated (:

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.