andrewmcgivery / ionic-ion-imagecachefactory Goto Github PK

.then is never called, also the failure function. Therefore unable to continue.

Saved or Image cache failed never written to console.

$ImageCacheFactory.Cache([
    $scope.latestPhoto + '',
    $scope.currentUser.profile_picture + ''
])
.then(function() {
    console.log('saved');
    $rootScope.hideSpinner();
}, function(a) {
    console.log('Image cache failed', a);
    $rootScope.hideSpinner();
});

I have implemented ionic-ion-imageCacheFactory into my project but it's not working on iOS devices, working on Android device properly.

Normal Mode (current):
If any images in the array error, whole method rejects promise.

Lazy Error Mode:
Will attempt to load all images regardless of errors. will pass array of failed images to resolved promise.

Getting ionic white screen of death on iOS 9.2, due to the import and use of the lib in the controller.
Not sure what happens, could not debug properly.

Kindly add bower.json on this and also kindly add this to bower.io

Please could you add a license to this repository? From here:

Generally speaking, the absence of a license means that the default copyright laws apply. This means that you retain all rights to your source code and that nobody else may reproduce, distribute, or create derivative works from your work. This might not be what you intend.

If you intend on this library being utilised, particularly by business, then a license is necessary.

Can you make this available in bower?

it would be nice to do a bower install of this :-)

Can you include a license in this project, even if it's All Rights Reserved? I'd prefer open source, of course.