GithubHelp home page GithubHelp logo

sportmastercardbonusservice's People

Contributors

andreylev avatar

Watchers

avatar avatar avatar

sportmastercardbonusservice's Issues

Переделать на более простые выражения

sportmastercardbonusservice/src/main/java/ru/rosbank/javaschool/service/CardBonusService.java

Lines 11 to 25 in 8b73805

if (currentPurchaseValue > BonusCard.zero) {
if (accumulatedAmount >= BonusCard.blueCardMinAmount && accumulatedAmount < BonusCard.silverCardMinAmount) {
bonus = BonusCard.blueCardBonusValue * (int) Math.floor(currentPurchaseValue / BonusCard.amountPerBonusUnit);
}
if (accumulatedAmount >= BonusCard.silverCardMinAmount && accumulatedAmount < BonusCard.goldCardMinAmount) {
bonus = BonusCard.silverCardBonusValue * (int) Math.floor(currentPurchaseValue / BonusCard.amountPerBonusUnit);
}
if (accumulatedAmount >= BonusCard.goldCardMinAmount) {
bonus = BonusCard.goldCardBonusValue * (int) Math.floor(currentPurchaseValue / BonusCard.amountPerBonusUnit);
}
}

  1. Уменьшить уровень вложенности кода
  2. Уменьшить количество логических выражений в одном if

На будущее: обычно капсом пишут такие поля

sportmastercardbonusservice/src/main/java/ru/rosbank/javaschool/BonusCard.java

Lines 5 to 15 in 887ebbd

public final static int blueCardMinAmount = 1;
public final static int silverCardMinAmount = 15001;
public final static int goldCardMinAmount = 151000;
public final static int blueCardBonusValue = 50;
public final static int silverCardBonusValue = 70;
public final static int goldCardBonusValue = 100;
public final static int amountPerBonusUnit = 1000;
public final static int zero = 0;

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.