android / codelab-slices-basic-codelab

Creating Android Slices

Slices are a new way to embed your app content in other surfaces. Slices are supported via a flexible templating system

Their templated content allow slices to feel at home in whatever surface hosts them, but their dynamic nature aims to be much more rich and updatable than existing APIs.

This codelab will guide you through creating a simple app that supports slices.

codelab-slices-basic-codelab's Issues

Question: why increase `sReqCode` for each call to `getChangeTempIntent` ?

This code:

private PendingIntent getChangeTempIntent(int value) {
    Intent intent = new Intent(ACTION_CHANGE_TEMP);
    intent.setClass(context, MyBroadcastReceiver.class);
    intent.putExtra(EXTRA_TEMP_VALUE, value);
    return PendingIntent.getBroadcast(getContext(), sReqCode++, intent,
            PendingIntent.FLAG_UPDATE_CURRENT);
}

I think it's not really needed to increase it all the time, as the request might interfere with other kinds of codes.

I think it's easier to split it to inc&dec. For example:

private PendingIntent getChangeTempIntent(int value, boolean hasIncreased) {
    Intent intent = new Intent(ACTION_CHANGE_TEMP);
    intent.setClass(context, MyBroadcastReceiver.class);
    intent.putExtra(EXTRA_TEMP_VALUE, value);
    return PendingIntent.getBroadcast(getContext(), hasIncreased ? 0 : 1, intent,
            PendingIntent.FLAG_UPDATE_CURRENT);
}

And the usage:

    SliceAction tempUp = new SliceAction(getChangeTempIntent(sTemperature + 1, true),
            IconCompat.createWithResource(context, R.drawable.ic_temp_up).toIcon(),
            "Increase temperature");
    SliceAction tempDown = new SliceAction(getChangeTempIntent(sTemperature - 1, false),
            IconCompat.createWithResource(context, R.drawable.ic_temp_down).toIcon(),
            "Decrease temperature");

Seems to work fine...

TemperatureSliceProvider has 2 TODO 3.4

TemperatureSliceProvider has 2 TODO 3.4

Bug: not using API 28 for compileSdkVersion

It has this instead:

compileSdkVersion 'android-P'

Will this codelab be updated to work in current Android Studio?

I got it running by updating lots of gradle config, but clicking the slice-viewer just locks my phone. In the emulator a permission request is shown, but when accepting nothing happens.

Please provide sourcecode of this codelab in kotlin

Bug: notifyChange doesnt' work on SliceProvider

In updateTemperature the call context.getContentResolver().notifyChange(uri, null); doesn't fire chain on onBindSlice in MySliceProvider.

I see TODO on parent class, however, is there any workarounds?

Doesn't show "Slice Viewer Sample wants to..."

Slice Viewer app doesn't show "Slice Viewer Sample wants to show Slices Basic Codelab slices" with base app in step 1.

Bug: minSdkVersion 19 , even though classes used need API 23

Or at least that's what the IDE says:

What is correct?