andygreenwell / groupslices.jl Goto Github PK

This is the error I get when I run groupslices(array,1) in Julia 0.6.0-rc3.
(Was working fine in 0.5.2)

WARNING: Array{T}(::Type{T}, m::Int) is deprecated, use Array{T}(m) instead.
Stacktrace:
 [1] depwarn(::String, ::Symbol) at ./deprecated.jl:70
 [2] Array(::Type{Int64}, ::Int64) at ./deprecated.jl:57
 [3] macro expansion at /Users/me/.julia/v0.6/GroupSlices/src/GroupSlices.jl:47 [inlined]
 [4] groupslices(::Array{Float64,2}, ::Int64) at /Users/me/.julia/v0.6/GroupSlices/src/GroupSlices.jl:34

I'll have a go at fixing this when I get a minute (figure out what the relevant buttons do).

Hi Andy

It looks like you haven't been here in a while. Would you be willing to transfer the ownership of this package to @mcabbott?

I do not see what the intended application of ic is. I have quoted the second example from the official tests below. Clearly, the original array E cannot be reconstructed as C[:,ic], where C = unique(E,2);, as it's supposed to according to the documentation. Shouldn't the proper value for ic be [1; 1; 2; 2; 3; 1; 3; 2; 2; 4]?

E = [1.0 1.0 2.0 2.0 1.0 1.0 1.0 2.0 2.0 2.0
1.0 1.0 2.0 2.0 2.0 1.0 2.0 2.0 2.0 1.0
1.0 1.0 1.0 1.0 1.0 1.0 1.0 1.0 1.0 2.0]

ib = Vector{Int}[[1,2,6],[3,4,8,9],[5,7],[10]]
ia = [1; 3; 5; 10]
ic = [1; 1; 3; 3; 5; 1; 5; 3; 3; 10]
ia1 = [1; 3; 5; 10]
ia2 = [6; 9; 7; 10]

As described in https://discourse.julialang.org/t/ann-plans-for-removing-packages-that-do-not-yet-support-1-0-from-the-general-registry/ we are planning on removing packages that do not support 1.0 from the General registry. This package has been detected to not support 1.0 and is thus slated to be removed. The removal of packages from the registry will happen approximately a month after this issue is open.

To transition to the new Pkg system using Project.toml, see https://github.com/JuliaRegistries/Registrator.jl#transitioning-from-require-to-projecttoml.
To then tag a new version of the package, see https://github.com/JuliaRegistries/Registrator.jl#via-the-github-app.

If you believe this package has erroneously been detected as not supporting 1.0 or have any other questions, don't hesitate to discuss it here or in the thread linked at the top of this post.