andyveloper / leaderboard-list

Leaderboard list with dynamically created elements using HTML, SCSS and JavaScript, using API calls to populate the list.

Project Name

• Leaderboard List

Website Name

• eXtreme (SC2 1v1 Ladder Ranking)

Clone the Project

• git clone https://github.com/Zeraltz/Leaderboard-list.git

Built With

• HTML, SCSS, JS, WEBPACK.
• VSCode

About

Creating a dynamically generated Leaderboard List as required by the program

Authors

👤 Author

• GitHub: @Zeraltz
• Twitter: @MauroCantillo_

🤝 Contributing

Contributions, issues, and feature requests are welcome!

Feel free to comment your opinion

Show your support

Give a ⭐️ if you like this project!

Acknowledgments

• Microverse

📝 License

This project is MIT licensed.

leaderboard-list's Issues

[p2p Code Review] Suggestions for improvement

Hi @Zeraltz 👋,

Your code is top-notch, congrats!

To Highlight 💯

✔️ Excellent UI Design (the best design I've seen for this project so far, congrats!)
✔️ Very good increment to the project adding the concepts of leagues/ranking
✔️ Clean and descriptive code
✔️ Well-organized code

Suggestions

• You are showing the user a status message when a new score is successfully added, which is very good! However, this is the way you are doing that right now:
  https://github.com/Zeraltz/Leaderboard-list/blob/33589b6ad14596d77981111edc84dce63bdb48cc/src/modules/leaderboardAPI.js#L42-L43
  You are using the JavaScript alert() method to accomplish this task. The problem with this approach is that alert messages interrupt the user workflow requiring the user to click the 'ok' button to keep using your application. So, in terms of UI/UX experience, this is considered not appropriate for displaying informative or status messages to the user. Instead, you could generate this message dynamically and show it to the user below or above your form, for example.
  For more information about why we should avoid using alert messages in this situation, please check out this forum post: https://ux.stackexchange.com/questions/4518/should-alert-boxes-be-avoided-at-any-cost