GithubHelp home page GithubHelp logo

Comments (3)

Harpush avatar Harpush commented on June 21, 2024

I don't think this is correct. Returning a boolean just goes around the problem of not having types.
I believe something like #51878 (comment) should be the solution.

from angular.

MaximSagan avatar MaximSagan commented on June 21, 2024

@Harpush

I don't think this is correct. Returning a boolean just goes around the problem of not having types. I believe something like #51878 (comment) should be the solution.

This is not supposed to replace any solution described in #51878. That issue describes a compile-time check, this issue describes a runtime check. Ideally we'd have both, but the compile-time check is non-trivial for reasons described there and does not seem likely to be implemented soon (hope I'm wrong), whereas this runtime check is trivial as you can see from my PR.

from angular.

Harpush avatar Harpush commented on June 21, 2024

What I meant is 99% of the cases where you are wrong about the input name or value is in development time. So a runtime validation seems too late. Unless there is a use case for it (guess some dynamic input name from server? But seems far fetched)

from angular.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.