C# ReferenceEquals CA2013 issues about clipper2

[AngusJohnson]

Hi Phil. As you know I'm not experienced with C#, but ISTM that this ReferenceEquals caveat only pertains to value types.
Are you suggesting that I'm comparing value types and not reference types?

if (ReferenceEquals(result.localMin, e.localMin)) return result;

[philstopford]

Rider seems to think this is comparing value types, hence the warning.

[AngusJohnson]

You're right. When I look at the disassembly, LocalMinima objects appear to be created on the stack.
I guess that since all fields are readonly this is both safe and sensible.

However, what I don't understand is how the lifetime of these stack objects is managed given that these objects soon seem to go out of scope (see AddLocMin and AddPathsToVertexList). I guess that's the wonder of C#'s memory management and GC.

[AngusJohnson]

Hopefully fixed now 😁.