anhility / bestinslotredux Goto Github PK

Message: ...lotRedux_BfaDungeons\BestInSlotRedux_BfaDungeons.lua:1: Usage: NewModule(name, [prototype, [lib, lib, lib, ...]): 'name' - Module 'BfaDungeons' already exists.
Time: Mon Feb 3 12:15:47 2020
Count: 1
Stack: ...lotRedux_BfaDungeons\BestInSlotRedux_BfaDungeons.lua:1: Usage: NewModule(name, [prototype, [lib, lib, lib, ...]): 'name' - Module 'BfaDungeons' already exists.
[string "=[C]"]: ?
[string "@interface\AddOns\Ace3\AceAddon-3.0\AceAddon-3.0.lua"]:239: in function `NewModule'
[string "@interface\AddOns\BestInSlotRedux_BfaDungeons\BestInSlotRedux_BfaDungeons.lua"]:1: in main chunk

Locals: (*temporary) = "Usage: NewModule(name, [prototype, [lib, lib, lib, ...]): 'name' - Module 'BfaDungeons' already exists."

Message: Interface\AddOns\BestInSlotRedux_BfaRaids\Uldir.lua:1: Usage: NewModule(name, [prototype, [lib, lib, lib, ...]): 'name' - Module 'Uldir' already exists.
Time: Mon Feb 3 12:15:47 2020
Count: 1
Stack: Interface\AddOns\BestInSlotRedux_BfaRaids\Uldir.lua:1: Usage: NewModule(name, [prototype, [lib, lib, lib, ...]): 'name' - Module 'Uldir' already exists.
[string "=[C]"]: ?
[string "@interface\AddOns\Ace3\AceAddon-3.0\AceAddon-3.0.lua"]:239: in function `NewModule'
[string "@interface\AddOns\BestInSlotRedux_BfaRaids\Uldir.lua"]:1: in main chunk

Locals: (*temporary) = "Usage: NewModule(name, [prototype, [lib, lib, lib, ...]): 'name' - Module 'Uldir' already exists."

Message: ...erface\AddOns\BestInSlotRedux_BfaRaids\DazarAlor.lua:1: Usage: NewModule(name, [prototype, [lib, lib, lib, ...]): 'name' - Module 'DazarAlor' already exists.
Time: Mon Feb 3 12:15:47 2020
Count: 1
Stack: ...erface\AddOns\BestInSlotRedux_BfaRaids\DazarAlor.lua:1: Usage: NewModule(name, [prototype, [lib, lib, lib, ...]): 'name' - Module 'DazarAlor' already exists.
[string "=[C]"]: ?
[string "@interface\AddOns\Ace3\AceAddon-3.0\AceAddon-3.0.lua"]:239: in function `NewModule'
[string "@interface\AddOns\BestInSlotRedux_BfaRaids\DazarAlor.lua"]:1: in main chunk

Locals: (*temporary) = "Usage: NewModule(name, [prototype, [lib, lib, lib, ...]): 'name' - Module 'DazarAlor' already exists."

Message: ...ce\AddOns\BestInSlotRedux_BfaRaids\EternalPalace.lua:234: attempt to index local 'eternalpalace' (a string value)
Time: Mon Feb 3 12:15:47 2020
Count: 1
Stack: ...ce\AddOns\BestInSlotRedux_BfaRaids\EternalPalace.lua:234: attempt to index local 'eternalpalace' (a string value)
[string "@interface\AddOns\BestInSlotRedux_BfaRaids\EternalPalace.lua"]:234: in main chunk

Locals: EternalPalace =

I have this Lua Errors
@anhility @zoveus @sandervanteinde

if I want to integrade a custom item with BfA, I get the error: "The minimum item level of custom items is 550!"
With BfA it is a much too high border for custom items. It should be more like 200.

In:"CustomItems.lua", if you change the lines:
11: local minimumIlvl = 550
to
11: local minimumIlvl = 200

and
138: if iLevel < 500 then
to
138: if iLevel < 200 then

it works at me.

(funny the old text said 550 and the code checks 500 :)

I've come across two LUa issues when using this addon in version 7.3.16 and it makes the addon almost unusable. Any thoughts?

Message: ...AddOns\BestInSlotRedux\Frames\RequestBestinslots.lua:55: attempt to concatenate a nil value
Time: 01/03/18 20:14:01
Count: 1
Stack: ...AddOns\BestInSlotRedux\Frames\RequestBestinslots.lua:55: attempt to concatenate a nil value
Interface\SharedXML\SharedBasicControls.lua:208: in function <Interface\SharedXML\SharedBasicControls.lua:207>
[C]: ?
...AddOns\BestInSlotRedux\Frames\RequestBestinslots.lua:55: in function SetText' ...AddOns\BestInSlotRedux\Frames\RequestBestinslots.lua:106: in function RegisterRaidTier'
...AddOns\BestInSlotRedux\Frames\RequestBestinslots.lua:858: in function DoRegister' ...AddOns\BestInSlotRedux\Frames\RequestBestinslots.lua:124: in function ProcessQueueItems'
...AddOns\BestInSlotRedux\Frames\RequestBestinslots.lua:135: in function <...AddOns\BestInSlotRedux\Frames\RequestBestinslots.lua:135>
Interface\SharedXML\C_TimerAugment.lua:16: in function <Interface\SharedXML\C_TimerAugment.lua:14>

Locals: errorMessage = "...AddOns\BestInSlotRedux\Frames\RequestBestinslots.lua:55: attempt to concatenate a nil value"
DisplayMessageInternal = defined @interface\SharedXML\SharedBasicControls.lua:191
MESSAGE_TYPE_ERROR = 0

Message: ...face\AddOns\BestInSlotRedux\Frames\GuildBiSLists.lua:247: invalid order function for sorting
Time: 01/03/18 20:18:51
Count: 2
Stack: ...face\AddOns\BestInSlotRedux\Frames\GuildBiSLists.lua:247: invalid order function for sorting
Interface\SharedXML\SharedBasicControls.lua:208: in function <Interface\SharedXML\SharedBasicControls.lua:207>
(tail call): ?
[C]: ?
...face\AddOns\BestInSlotRedux\Frames\GuildBiSLists.lua:247: in function <...face\AddOns\BestInSlotRedux\Frames\GuildBiSLists.lua:234>
(tail call): ?
...face\AddOns\BestInSlotRedux\Frames\GuildBiSLists.lua:395: in function GeneratePlayerScrollContainer' ...face\AddOns\BestInSlotRedux\Frames\GuildBiSLists.lua:449: in function <...face\AddOns\BestInSlotRedux\Frames\GuildBiSLists.lua:447> (tail call): ? [C]: ? [string "safecall Dispatcher[3]"]:9: in function <[string "safecall Dispatcher[3]"]:5> (tail call): ? ...ddOns\BestInSlotRedux\Libs\AceGUI-3.0\AceGUI-3.0.lua:314: in function Fire'
...ux\Libs\AceGUI-3.0\widgets\AceGUIWidget-DropDown.lua:442: in function <...ux\Libs\AceGUI-3.0\widgets\AceGUIWidget-DropDown.lua:433>
(tail call): ?
[C]: ?
[string "safecall Dispatcher[3]"]:9: in function <[string "safecall Dispatcher[3]"]:5>
(tail call): ?
...ddOns\BestInSlotRedux\Libs\AceGUI-3.0\AceGUI-3.0.lua:314: in function `Fire'
...s\AceGUI-3.0\widgets\AceGUIWidget-DropDown-Items.lua:351: in function <...s\AceGUI-3.0\widgets\AceGUIWidget-DropDown-Items.lua:341>

Locals:

Message: ...face\AddOns\BestInSlotRedux\Frames\GuildBiSLists.lua:247: invalid order function for sorting
Time: 01/03/18 20:20:09
Count: 1
Stack: ...face\AddOns\BestInSlotRedux\Frames\GuildBiSLists.lua:247: invalid order function for sorting
Interface\SharedXML\SharedBasicControls.lua:208: in function <Interface\SharedXML\SharedBasicControls.lua:207>
[C]: ?
[C]: ?
...face\AddOns\BestInSlotRedux\Frames\GuildBiSLists.lua:247: in function <...face\AddOns\BestInSlotRedux\Frames\GuildBiSLists.lua:234>
(tail call): ?
...face\AddOns\BestInSlotRedux\Frames\GuildBiSLists.lua:395: in function GeneratePlayerScrollContainer' ...face\AddOns\BestInSlotRedux\Frames\GuildBiSLists.lua:484: in function Draw'
...terface\AddOns\BestInSlotRedux\Frames\FramesCore.lua:534: in function <...terface\AddOns\BestInSlotRedux\Frames\FramesCore.lua:433>
...terface\AddOns\BestInSlotRedux\Frames\FramesCore.lua:899: in function ShowFrame' ...terface\AddOns\BestInSlotRedux\Frames\FramesCore.lua:911: in function func'
Interface\AddOns\BestInSlotRedux\Core.lua:714: in function ?' Interface\FrameXML\ChatFrame.lua:4512: in function ChatEdit_ParseText'
Interface\FrameXML\ChatFrame.lua:4180: in function ChatEdit_SendText' Interface\FrameXML\ChatFrame.lua:4216: in function <Interface\FrameXML\ChatFrame.lua:4212> [C]: in function ChatEdit_OnEnterPressed'
[string ":OnEnterPressed"]:1: in function <[string ":OnEnterPressed"]:1>

Locals: errorMessage = "...face\AddOns\BestInSlotRedux\Frames\GuildBiSLists.lua:247: invalid order function for sorting"
DisplayMessageInternal = defined @interface\SharedXML\SharedBasicControls.lua:191
MESSAGE_TYPE_ERROR = 0

When returning to Krasus' Landing after a Dungeon or Raid I get the following Lua error.

...\BestInSlotRedux\Modules\ZoneDetection.lua:78: bad argument #2 to 'strsplit' (string expected, got nil)

I cant right click and use item on slots.

Hi I got today the error with the addon that I cant load it with the erro taken from a bug addon:

6x ...ux_LegionDungeons\BestInSlotRedux_LegionDungeons-v7.3.06.lua:1580: attempt to call method 'RegisterExpansion' (a nil value)
...ux_LegionDungeons\BestInSlotRedux_LegionDungeons-v7.3.06.lua:1580: in function <...ux_LegionDungeons\BestInSlotRedux_LegionDungeons.lua:1579>
(tail call): ?
[C]: ?
[string "safecall Dispatcher[1]"]:9: in function <[string "safecall Dispatcher[1]"]:5>
(tail call): ?
...s\BestInSlotRedux\Libs\AceAddon-3.0\AceAddon-3.0-12.lua:558: in function `EnableAddon'
...s\BestInSlotRedux\Libs\AceAddon-3.0\AceAddon-3.0-12.lua:651: in function <...s\BestInSlotRedux\Libs\AceAddon-3.0\AceAddon-3.0.lua:636>
[C]: in function `LoadAddOn'
FrameXML\UIParent.lua:421: in function `UIParentLoadAddOn'
FrameXML\UIParent.lua:516: in function `TimeManager_LoadUI'
FrameXML\UIParent.lua:1098: in function <FrameXML\UIParent.lua:995>

Locals:
nil

Hi there

I really like this addon and use it on all of my chars in wow but today I found an "maybe" issue!

I was in my orderhall just sending away my followers and doing some sort my bags stuff and then I opened addon usage to see my cpu load of the addons because I'm allways trying to find addons that are taking to much of cpu load for my tast and then switch them of for raiding or search for an alternative!

I know tradeskillmaster is a ton of load on memory and cpu when doing something in the bags or auctionhouse but BestInSlotRedux nealy took doubble of the cpu load and I was in no raid or anything else and did not do anything with it at all, so how comes that it take so much cpu load when I do not do anything with it or even would not even need it in that situation?

Thank you in advance

Need to add an "all" option to the dropdown box when requesting BiS lists.

Hi guys!
I asked my guildmates as well and they have the same problem.
It's not possible to disable the tooltip option "Show BestInSlot in boss tooltips" in the option tab.
When you untick it, it always gets enabled again, when you switch tabs or close the window.
Hope there is a fix for this, because it lags a litle bit, when I hover over a boss.
Kind regards,
Izno

Is there a way so you can add a same item but different versions (normal,heroic and mythic ) in normal,heroic and mythic list at same time ?
Also is there a way to import bis list from wowhead or raidbot ?

When shift right clicking an Azerite item in the bestinslot redux UI the item is entered in to the chat input bar.

I would expect this to open the Azerite trait window not paste the item in chat input.

Everything is missing. Just nothing. =)

https://imgur.com/a/Vhsdd

Frames/RaidTierOverview.lua

Since 7.3 is GuildControlSetRank() a protected function so report to officer chat have been disabled until a solution is found.

When right-clicking a guildie -> Show history it throws a bug and lock up the addon, forcing a /reload.

I'm a bit of an altoholic (okay a lot of an altoholic), but I mostly only raid with my main. This addon is absolutely great for helping me keep gear lists for my main and keeping gear straight on my alts. I was making my own Google sheet before I found this addon (which was a headache!).

I was hoping an LFR option (list, gear, tooltip info, etc) could be added. I think WF/TF gear makes a great argument for adding LFR stuff to the addon. It can't be added custom because the addon already says the item is assigned. But with 11 alts, LFR is usually all I have time to do on them.

Add mechagon to nyah raid 8.3 setup

see title

Known issue. Will fix this as I get access to the bosses during the opening week.

Currently is shows an empty gear list until you pick a spec.

Might be due to development version. Will test on release version.

For these strings:

L["Deleting this is irreversible. Are you sure?"] = [=[
Cette action est irr\195\169versible. Voulez-vous continuer ?]=]

L[ [=[You can't delete this custom list.
It is in use at:
%s]=] ] = [=[Vous ne pouvez pas supprimer cette liste personnalis\195\169e.
Elle est utilis\195\169e pour :
%s]=]

L["You've picked: %s"] = [=[Vous avez choisi :
%s]=]

Seems like CurseForge don't encode to \r\n like it should.

Localization missing for antorus and ToS modules.

Will there be an update for patch 8.2 in the near future by any chance love this addon so helpful

Just got this LUA error after adding a custom item and choosing it in BiS:

10x BestInSlotRedux\Frames\CustomItems.lua:153: attempt to index field 'inputbox' (a nil value)
BestInSlotRedux\Frames\CustomItems.lua:153: in function `DisableInput'
BestInSlotRedux\Frames\CustomItems.lua:266: in function `TryGenerateCustomItem'
BestInSlotRedux\Frames\CustomItems.lua:69: in function `func'
BestInSlotRedux\BestInSlotEvent.lua:70: in function `SendEvent'
BestInSlotRedux\Core.lua:491: in function <BestInSlotRedux\Core.lua:491>
[string "safecall Dispatcher[2]"]:4: in function <[string "safecall Dispatcher[2]"]:4>
[C]: ?
[string "safecall Dispatcher[2]"]:13: in function `?'
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:90: in function `Fire'
Ace3\AceEvent-3.0\AceEvent-3.0-4.lua:120: in function <Ace3\AceEvent-3.0\AceEvent-3.0.lua:119>

Locals:
nil

Hi, in the Bosstooltip inside the Raid i did not see my BiS items, which i could loot from a boss. BiS List is set for each difficulty. I play with the german client.

Dear BestInSlotRedux Team,

first of all, thank you for your update. I found one bug, while I want to add a new custom item, which is a Uldir trash drop. The itemlevel to add an Item has to be above 550, which doesn't cover the itemlevel squish.
Have a look to this screenshot: https://i.imgur.com/ZUtgDKj.png

Thank you!

Kind regards,
Pandha

Your personal BiS lists are loaded per character so you currently can't see any of your alts BiS lists.
Idea is to add a new panel with BiS lists for all your alts on the same realm.

Would be possiable to add option to show on 1 list both 2h and 1H+OH if character can use both of this versions?

Might be due to being development version as the function ask for addon version, which is automated from a tag.
Must test on live build later.

When I have ElvUI enable at the same time I get this strange thin border around the manager window. After some troubleshooting I have found that if disable Ace 3 it resolves this strange border but of course removes some of my skins so I am not sure what the conflict with the two is. Here is a picture of this thin border https://imgur.com/a/1luhnjF.

151972 [Sullied Seal of the Pantheon]
151973 [Collar of Null-Flame]

are jewelry and is filtered-out by all specs.

I believe it resides in the statfilters of the core at the line 860, might be wrong can't test it right now

    canUse = tContains(statFilter, specializationId)
     end
   else
     canUse = replace false by true

on the Overview tab, the "Report you BestInSlot to:" option at the bottom the window stays on the screen when you close the options dialog down. Doesn't matter what tab was open, that dropdown option doesn't go away and sticks on the screen wherever it was before the dialog was closed. BugSack errors are below

1x ...eBestInSlotRedux\Frames\RaidTierOverview.lua:240: attempt to index upvalue 'reportButton' (a nil value) [string "@BestInSlotRedux\Frames\RaidTierOverview.lua"]:240: in function UpdateContent'
[string "@BestInSlotRedux\Frames\RaidTierOverview.lua"]:284: in function customcallback' [string "@BestInSlotRedux\Frames\FramesCore.lua"]:804: in function <BestInSlotRedux\Frames\FramesCore.lua:801> [string "=[C]"]: ? [string "@AddOnSkins\Libs\Ace3\AceGUI-3.0\AceGUI-3.0-41.lua"]:72: in function <...ddOns\AddOnSkins\Libs\Ace3\AceGUI-3.0\AceGUI-3.0.lua:70> [string "@AddOnSkins\Libs\Ace3\AceGUI-3.0\AceGUI-3.0-41.lua"]:306: in function Fire'
[string "@AddOnSkins\Libs\Ace3\AceGUI-3.0-41\widgets\AceGUIWidget-DropDown.lua"]:437: in function <...bs\Ace3\AceGUI-3.0\widgets\AceGUIWidget-DropDown.lua:428>
[string "=[C]"]: ?
[string "@AddOnSkins\Libs\Ace3\AceGUI-3.0\AceGUI-3.0-41.lua"]:72: in function <...ddOns\AddOnSkins\Libs\Ace3\AceGUI-3.0\AceGUI-3.0.lua:70>
[string "@AddOnSkins\Libs\Ace3\AceGUI-3.0\AceGUI-3.0-41.lua"]:306: in function Fire' [string "@AddOnSkins\Libs\Ace3\AceGUI-3.0-41\widgets\AceGUIWidget-DropDown-Items.lua"]:351: in function <...3\AceGUI-3.0\widgets\AceGUIWidget-DropDown-Items.lua:341>

6x ...eBestInSlotRedux\Frames\RaidTierOverview.lua:413: attempt to concatenate local 'id' (a boolean value) [string "@BestInSlotRedux\Frames\RaidTierOverview.lua"]:413: in function Draw'
[string "@BestInSlotRedux\Frames\FramesCore.lua"]:197: in function func' [string "@BestInSlotRedux\Frames\FramesCore.lua"]:125: in function SetFrameSize'
[string "@BestInSlotRedux\Frames\FramesCore.lua"]:197: in function <BestInSlotRedux\Frames\FramesCore.lua:176>
[string "=(tail call)"]: ?
[string "=[C]"]: ?
[string "@AddOnSkins\Libs\Ace3\AceGUI-3.0\AceGUI-3.0-41.lua"]:72: in function <...ddOns\AddOnSkins\Libs\Ace3\AceGUI-3.0\AceGUI-3.0.lua:70>
[string "@AddOnSkins\Libs\Ace3\AceGUI-3.0\AceGUI-3.0-41.lua"]:306: in function Fire' [string "@AddOnSkins\Libs\Ace3\AceGUI-3.0-41\widgets\AceGUIWidget-InteractiveLabel.lua"]:23: in function <...AceGUI-3.0\widgets\AceGUIWidget-InteractiveLabel.lua:22>

Can y'all please add an option to view all dungeons/instances? For example, I want to see a list of all the non-raid dungeons I've picked out to decide which is the best place for me to go. Currently, I have to click through all ~10 instances to see which ones have loot I'm after.

Show who needs item on tier tokens

maybe something in Ace3 code?

Testing committing a task/issue to github.

Downloaded this addon today and I (and at least one other person that I know of) are getting these errors when trying to use the addon:

• 1x ...x\Libs\LibDBIcon-1.0\LibDBIcon-1.0\LibDBIcon-1.0.lua:12: LibDBIcon-1.0 requires LibDataBroker-1.1.
  [C]: in function `error'
  ...x\Libs\LibDBIcon-1.0\LibDBIcon-1.0\LibDBIcon-1.0.lua:12: in main chunk
  Locals:
  (*temporary) = "LibDBIcon-1.0 requires LibDataBroker-1.1."

• 1x BestInSlotRedux\MiniMapLDB.lua:3: Cannot find a library instance of "LibDataBroker-1.1".
  [C]: in function error' Ace3\LibStub\LibStub.lua:23: in function LibStub'
  BestInSlotRedux\MiniMapLDB.lua:3: in main chunk
  Locals:
  (*temporary) = "Cannot find a library instance of "LibDataBroker-1.1"."

• 1x BestInSlotRedux\Core.lua:507: attempt to call method 'MiniMapButtonVisible' (a nil value)
  BestInSlotRedux\Core.lua:507: in function <BestInSlotRedux\Core.lua:498>
  (tail call): ?
  [C]: ?
  [string "safecall Dispatcher[1]"]:9: in function <[string "safecall Dispatcher[1]"]:5>
  (tail call): ?
  Ace3\AceAddon-3.0\AceAddon-3.0-12.lua:558: in function EnableAddon' Ace3\AceAddon-3.0\AceAddon-3.0-12.lua:651: in function <Ace3\AceAddon-3.0\AceAddon-3.0.lua:636> [C]: in function LoadAddOn'
  FrameXML\UIParent.lua:421: in function UIParentLoadAddOn' FrameXML\UIParent.lua:516: in function TimeManager_LoadUI'
  FrameXML\UIParent.lua:1098: in function <FrameXML\UIParent.lua:995>
  Locals:
  nil

Sub wrists and gloves

Hi. Russian localization gives an error.
https://imgur.com/a/UCqrv

It would be very helpful to a lot of people if we could just export our Guild BiS to a spreadsheet. Is there a way to do it?

thx

Where a Legendary is chosen as BiS could we please always see the 1000 ilevel version? Otherwise it doesn’t look like the slot is filled simply because my equipped item is > ilevel than the original item when it dropped.

Guild BiS lists - Right Click Icon
https://imgur.com/a/Hw2kn

Hey, I'm Sannath (In the contributors for the original addon), still developping the addon for internal guild use.

Good luck with the addon ! :)

Here is the code for trashloots for antorus :

  -----------------------------------
  ----- Trashloots
  -----------------------------------
  local bossName = "Trash Loots"
  local lootTable = {
  	152084, --Gloves of Abhorrent Strategies
	152085, --Cuffs of the Viridian Flameweavers
	153018, --Corrupted Mantle of the Felseekers
	151993, --Leggings of the Sable Stalkers
	152087, --Sinuous Kerapteron Bindings
	152413, --Felflame Inferno Shoulderpads
	152088, --Horror Fiend-Scale Breastplate
	152089, --Wristguards of Ominous Forging
	152682, --Greaves of the Felblade Defenders
	153019, --Hulking Demolisher Legplates
	152091, --Wristguards of the Dark Keepers
	152090, --Impenetrable Garothi Breastplate
  }
  
  self:RegisterBossLoot(ATBT, lootTable, bossName)

Add all the old translations to the CurseForge page for automatic localization.

Need to find a way to make them separate entities in the database as currently are they identified by their itemID and would overwrite itself.

I am geeting this type of bug
p3lim-wow/BonusRollPreview#36

when i try to look items in addon .I just get black square like in those pics from other addon.

The previous translations were unfortunately lost when I took over the project. If you are good with translation, please help at https://wow.curseforge.com/projects/bestinslotredux/localization or contact me.
Translators will be written inside parentheses.

Completely translated:

• Spanish - Iberian (gejobj)
• French (Meivyn, nitrodroki)
• Spanish - Latin American (xylons)
• Brazilian Portuguese (Carlinha)
• Russian (Hubbotu & SintlKun)
• Traditional Chinese (gaspy10)

Currently being translated:

• German (Rushgarroth1337 & SpeedsharkX)

Needing translation:

• Italian
• Korean
• Simple Chinese