anirudhbhat / subdb.go

Download subtitle from your terminal.

subdb.go

Download subtitle from your terminal.

Usage

subdb -p "movie path" -l "language[en,es,fr,it,nl,pl,pt,ro,sv,tr]"

subdb.go's Issues

Use flag for parameters

Use the flag package to parse the files; It allows you to provide named parameters, and a help menu (which is really nice in this case, since you don't actually provide an example of how the language is formatted).

And finally, in the url-string you use ",en", where you should really only use "en":
This:

url := "http://api.thesubdb.com/?action=download&hash=" + hash + "&language=" + language + ",en"

Should be:

url := "http://api.thesubdb.com/?action=download&hash=" + hash + "&language=" + language + "en"

Code for using flag:

var (
    filepath string
    language string
)

func init() {
    flag.StringVar(&filepath, "f", "", "Path to the movie file")
    flag.StringVar(&language, "l", "en", "The required language of the subtitles")
}

func main() {
        flag.Parse()

    if filepath == "" {
        fmt.Println("Provide path to movie file etc.")
        os.Exit(1)
    }

        // Validate that language is of length == 2 etc.
}

Example usage:

subdb -f movie.mp4
subdb -f movie.mp4 -l it

Use same name as the video file for the .srt file

This will make it easy for VLC to pick up the file

If an error occurs in the Client.Do call an attempt to parse the body is still made

Currently

...
resp, err := client.Do(req)
if err != nil {
    fmt.Println(err) // only on connection error etc.
}

Should be:

...
resp, err := client.Do(req)
if err != nil {
    fmt.Println(err) // only on connection error etc.
    os.Exit(1)
}

rename to subdgo or something without .go in it.

It is annoying having to type a dot in the name.

Make use of "notify-send" optional

It does not work on my Mac

Only attempt to download when resp.StatusCode == 200

According to the api documentation, the possible statusCodes are:

400 = Bad Request
404 = Not Found
200 = Success