anitab-org / powerup-ios Goto Github PK

This is the template provided by Github and takes care of every case. As the project will grow we will be using Pods for sure.

Description

As a player, I want to complete the "Store" scenario,
so that I can earn karma points and buy new things!

Mocks

Borrow the Phone

Acceptance Criteria

User interacts with an NPC.
Once conversation is finished, user is notified with the # of karma points earned.

Definition of Done

Passes all regression tests.
Passes testing per acceptance criteria items.
Approved by UI team.
Able to show feature in demo.

Estimation
TBD

In certain instances of the game, newly created character is not saved and only body framework of Avatar is displayed. This usually happens when we click Start button to go to a previous instance of the game.

Do we need an avatar table in our database? And is yes, what fields should be included in the table?

Like "Map/Journey", "iPod Troubles", etc.

Description

As an Student,
I want to see where I can improve in my code,
so that I can manage grow my technical strengths.

Mocks

N/A

Acceptance Criteria

• Checklist below is complete and included in a comment on this issue. (Will transfer to Wiki later.)
• Feedback is given to the developer. (Comment on the PR.)

Definition of Done

 Complete this Code Review Checklist (Adapt as Needed).

General

• Does the code work? Does it perform its intended function, the logic is correct etc.
• Is all the code easily understood?
• Does it conform to your agreed coding conventions? These will usually cover location of braces, variable and function names, line length, indentations, formatting, and comments.
• Is there any redundant or duplicate code?
• Is the code as modular as possible?
• Can any global variables be replaced?
• Is there any commented out code?
• Do loops have a set length and correct termination conditions?
• Can any of the code be replaced with library functions?
• Can any logging or debugging code be removed?

Security

• Are all data inputs checked (for the correct type, length, format, and range) and encoded?
• Where third-party utilities are used, are returning errors being caught?
• Are output values checked and encoded?
• Are invalid parameter values handled?

Documentation

• Do comments exist and describe the intent of the code?
• Are all functions commented?
• Is any unusual behavior or edge-case handling described?
• Is the use and function of third-party libraries documented?
• Are data structures and units of measurement explained?
• Is there any incomplete code? If so, should it be removed or flagged with a suitable marker like ‘TODO’?

Testing

• Is the code easily testable? i.e. don’t add too many or hide dependencies, unable to initialize objects, test frameworks can use methods etc.
• Do tests exist and are they comprehensive? i.e. has at least your agreed on code coverage.
• Do unit tests actually test that the code is performing the intended functionality?
• Are arrays checked for ‘out-of-bound’ errors?
• Could any test code be replaced with the use of an existing API?

Estimation

• 1.5 Hours

Description

As an User,
I want to be able to click on several accessories of the same type when shopping without karma points being deducted for each click,
so that I see how each accessory of that type looks and decide which one I like better.

Mocks
N/A

Acceptance Criteria

User clicks on an accessor to purchase it and karma points are deducted.
User clicks on another one of the same accessory type.
The avatar is changed but no additional karma points are deducted.

Definition of Done

Passes all regression tests.
Passes testing per acceptance criteria items.
Approved by UI team.
Able to show feature in demo.

Estimation
tbd

Points are received for making 'good' decisions during the game. These can be used to buy accessories for the avatar.

Description

As a mentor, I want tests written for already implemented code, in order to ensure that future changes will not deteriorate consisting code and to avoid bugs. So far implemented code does not include Unit Tests (apart from Minesweeper game).

Acceptance Criteria

• include Unit Tests
• meaningful Testdata
• positive / negative Tests where useful

Definition of Done

-Passes user testing per acceptance criteria items.
-Unit tests run successfully
-Approval by mentors

Estimation

Description

As a player, I want to complete the "School" scenario,
so that I can earn karma points and buy new things!

Mocks

Sex scene

Acceptance Criteria

User interacts with an NPC.
Once conversation is finished, user is notified with the # of karma points earned.

Definition of Done

Passes all regression tests.
Passes testing per acceptance criteria items.
Approved by UI team.
Able to show feature in demo.

Estimation
TBD

Description

As a developer,
I want to code the minesweeper game,
so that I can code it into the sex scenario.

Mocks

Acceptance Criteria

• Red, Green, and White Dots all consistent.
• Winning Screen
• Losing Screen

Definition of Done

• Passes user testing per acceptance criteria items.
• Featured in design meeting.
• Approved by UI team. (Dil & May)

Estimation

5 Hours

Description

As a user,
I want the app to handle errors appropriately without crashing.

Acceptance Criteria

Errors that the app cannot correct will either notify the user (without crashing), and/or fail silently if the game is still able to continue.

Definition of Done

Passes unit testing of error conditions.

Estimation
tbd

As a developer, I want to have a centralized access to the database so that I can more easily implement new features and enhancements in the app without duplicating code.

Acceptance Criteria:
All database access in the app is refactored to go through a proxy class

Definition of Done:
Approved by code review

As a product owner, I want the code to be easily understood so that modifications to existing screens can be made quickly without breaking code and introducing bugs. For example, Some screens in the app are actually multiple screens in the storyboard each with its own view controller and segue code. This is unnecessarily complex and duplicates code and storyboard screens. Each main screen should be redesigned so that it requires only one storyboard screen with one view controller. For example, "Choices-.swift" views should be merged and Scene.swift views should be merged.

Acceptance Criteria:

• A developer who is new to the project can readily identify the view in the storyboard that pertains to a specific screen in the app.
• Changes to a screen have to be made in one view only in the storyboard

Definition of Done:

• Sequential screens and view controller code are consolidated into one screen and view controller.
• Approved via code review.

Having completed level1, accessories can be bought using the points received and chosen in the 2nd-dressing room (this is already implemented!).

These accessories, as well as changes made in the current avatar (user can change hairstyle or clothes at the same time), should be carried through in the following levels.

Description

As a developer and mentor, I want our code to be integrated with a continuous integration and build system to ensure code quality and make code reviews easier for both mentors and developers.

Acceptance Criteria

• setting up and configuring Travis-ci build management system
• Travis-ci integrated with github
• Current repo builds successfully

Definition of Done

-Passes user testing per acceptance criteria items.
-Successful build based on latest version
-Approval by mentors

Estimation

Description

As an Student,
I want to view all the work I need to do,
so that I can manage my time and program with weekly reports on time.

Mocks

N/A

Acceptance Criteria

• Student can view all user stories in the issues list.
• User stories follow this format.
• Includes labels, assignees, and added to the "Student Tasks" Project board.

Definition of Done

• All 5 scenarios are covered for each stage (Library, Store, Hospital, School, and Home).
• There are 2 scenarios for Home (1 - party scene, 1 - sexual assault scene).

Estimation

• 1 Hour

Description

As an Admin,
I want to download the current code,
so that I can perform user tests and check on the end result.

Mocks

N/A

Acceptance Criteria

• All PRs have been reviewed by at least 1 mentor.
• Code merged into the correct branch "GSoC17"
• When possible, create a release file is provided in the repo.

Definition of Done

• Week 2's code is able to be downloaded from the GSoC17 Branch in the project's repo.

Estimation

• 0.5 Hours

Steps to reproduce

1. Open the PowerUp iOS app and click on Start button

2. Enter level 1 from map and play the level

3. Depending on various responses the level will reach to a conclusion

4. The last screen gets tilted automatically tilted to Landscape view than Portrait view

Here is the last screen

Description

As an Student,
I want to see where I can improve in my code,
so that I can manage grow my technical strengths.

Mocks

N/A

Acceptance Criteria

• Checklist below is complete and included in a comment on this issue. (Will transfer to Wiki later.)
• Feedback is given to the developer. (Comment on the PR.)

Definition of Done

 Complete this Code Review Checklist (Adapt as Needed).

General

• Does the code work? Does it perform its intended function, the logic is correct etc.
• Is all the code easily understood?
• Does it conform to your agreed coding conventions? These will usually cover location of braces, variable and function names, line length, indentations, formatting, and comments.
• Is there any redundant or duplicate code?
• Is the code as modular as possible?
• Can any global variables be replaced?
• Is there any commented out code?
• Do loops have a set length and correct termination conditions?
• Can any of the code be replaced with library functions?
• Can any logging or debugging code be removed?

Security

• Are all data inputs checked (for the correct type, length, format, and range) and encoded?
• Where third-party utilities are used, are returning errors being caught?
• Are output values checked and encoded?
• Are invalid parameter values handled?

Documentation

• Do comments exist and describe the intent of the code?
• Are all functions commented?
• Is any unusual behavior or edge-case handling described?
• Is the use and function of third-party libraries documented?
• Are data structures and units of measurement explained?
• Is there any incomplete code? If so, should it be removed or flagged with a suitable marker like ‘TODO’?

Testing

• Is the code easily testable? i.e. don’t add too many or hide dependencies, unable to initialize objects, test frameworks can use methods etc.
• Do tests exist and are they comprehensive? i.e. has at least your agreed on code coverage.
• Do unit tests actually test that the code is performing the intended functionality?
• Are arrays checked for ‘out-of-bound’ errors?
• Could any test code be replaced with the use of an existing API?

Estimation

• 1.5 Hours

Description

As an Student,
I want to see where I can improve in my code,
so that I can manage grow my technical strengths.

Mocks

N/A

Acceptance Criteria

• Checklist below is complete and included in a comment on this issue. (Will transfer to Wiki later.)
• Feedback is given to the developer. (Comment on the PR.)

Definition of Done

 Complete this Code Review Checklist (Adapt as Needed).

General

• Does the code work? Does it perform its intended function, the logic is correct etc.
• Is all the code easily understood?
• Does it conform to your agreed coding conventions? These will usually cover location of braces, variable and function names, line length, indentations, formatting, and comments.
• Is there any redundant or duplicate code?
• Is the code as modular as possible?
• Can any global variables be replaced?
• Is there any commented out code?
• Do loops have a set length and correct termination conditions?
• Can any of the code be replaced with library functions?
• Can any logging or debugging code be removed?

Security

• Are all data inputs checked (for the correct type, length, format, and range) and encoded?
• Where third-party utilities are used, are returning errors being caught?
• Are output values checked and encoded?
• Are invalid parameter values handled?

Documentation

• Do comments exist and describe the intent of the code?
• Are all functions commented?
• Is any unusual behavior or edge-case handling described?
• Is the use and function of third-party libraries documented?
• Are data structures and units of measurement explained?
• Is there any incomplete code? If so, should it be removed or flagged with a suitable marker like ‘TODO’?

Testing

• Is the code easily testable? i.e. don’t add too many or hide dependencies, unable to initialize objects, test frameworks can use methods etc.
• Do tests exist and are they comprehensive? i.e. has at least your agreed on code coverage.
• Do unit tests actually test that the code is performing the intended functionality?
• Are arrays checked for ‘out-of-bound’ errors?
• Could any test code be replaced with the use of an existing API?

Estimation

• 1.5 Hours

DevChange made in Android App:

When the app starts for the first time, the user should be directed to the changing room directly

Edit project settings and code to eliminate the compiler warnings.

On macOS X, the .DS_Store file should not be under version control. It's an OS-generated file and not part of the source code. It should be removed from the repo and an entry added to the .gitignore file.

checking if slack integration is working.

Description

As a user I want to play the Sink to Swim game,
to learn the truths and myths about contraception.

Mock

Acceptance Criteria

• Transition to/from the minigame
• User interacts with an NPC.
• Also add a warning dialogue before the scenario since it addresses a sensitive issue.
• Once conversation is finished, user is notified with the # of karma points earned.
• Unit Tests
• Include UI Design

Definition of Done

-Passes user testing per acceptance criteria items.
-Demo during Meeting
-Approved by Mentors & UI team. (Dil & May)

Estimation

Description

As a player,I want to complete the "Hospital" scenario,
so that I can earn karma points and buy new things!

Mocks

image

Acceptance Criteria

User interacts with an NPC.
Once conversation is finished, user is notified with the # of karma points earned.

Definition of Done

Passes all regression tests.
Passes testing per acceptance criteria items.
Approved by UI team.
Able to show feature in demo.

Estimation
TBD

Steps to reproduce the bug

1. Install app for the first time.

2. Click on Start button
   (We will get an alert asking to create a new user)

3. Click on New User button

4. Navigate back to the home page without creating a user.

5. Click on Start Button

6. Navigates to the map but the user is not created ... Resulting an inappropriate user image.

The following is the screenshot showing the above mentioned bug.

(Since the user is not created .... It doesn't have a head.)

I would like to fix this bug.
Thank you :)

Description

As an Admin,
I want to download the current code,
so that I can perform user tests and check on the end result.

Mocks

N/A

Acceptance Criteria

• All PRs have been reviewed by at least 1 mentor.
• Code merged into the correct branch "GSoC17"
• When possible, create a release file is provided in the repo.

Definition of Done

• Week 1's code is able to be downloaded from the GSoC17 Branch in the project's repo.

Estimation

• 0.5 Hours

The left and right buttons of the hair, eyes, clothes and face stop when they reach the end points of the hair, eyes, clothes and face image arrays respectively. The right button should come back to the first image in the array after it reaches the end of the images and the left button should go to the end of the array after it reaches the first image. This can maintain the flow of the application.

As you can see there is layout issue in iPad( also #53 ). i'd like to add autolayout parameters to it . should i submit a PR for this ?

Description

As an Student,
I want to see where I can improve in my code,
so that I can manage grow my technical strengths.

Mocks

N/A

Acceptance Criteria

• Checklist below is complete and included in a comment on this issue. (Will transfer to Wiki later.)
• Feedback is given to the developer. (Comment on the PR.)

Definition of Done

 Complete this Code Review Checklist (Adapt as Needed).

General

• Does the code work? Does it perform its intended function, the logic is correct etc.
• Is all the code easily understood?
• Does it conform to your agreed coding conventions? These will usually cover location of braces, variable and function names, line length, indentations, formatting, and comments.
• Is there any redundant or duplicate code?
• Is the code as modular as possible?
• Can any global variables be replaced?
• Is there any commented out code?
• Do loops have a set length and correct termination conditions?
• Can any of the code be replaced with library functions?
• Can any logging or debugging code be removed?

Security

• Are all data inputs checked (for the correct type, length, format, and range) and encoded?
• Where third-party utilities are used, are returning errors being caught?
• Are output values checked and encoded?
• Are invalid parameter values handled?

Documentation

• Do comments exist and describe the intent of the code?
• Are all functions commented?
• Is any unusual behavior or edge-case handling described?
• Is the use and function of third-party libraries documented?
• Are data structures and units of measurement explained?
• Is there any incomplete code? If so, should it be removed or flagged with a suitable marker like ‘TODO’?

Testing

• Is the code easily testable? i.e. don’t add too many or hide dependencies, unable to initialize objects, test frameworks can use methods etc.
• Do tests exist and are they comprehensive? i.e. has at least your agreed on code coverage.
• Do unit tests actually test that the code is performing the intended functionality?
• Are arrays checked for ‘out-of-bound’ errors?
• Could any test code be replaced with the use of an existing API?

Estimation

• 1.5 Hours

iPhone 7

iPhone 7 Plus

Description

As an Admin,
I want to download the current code,
so that I can perform user tests and check on the end result.

Mocks

N/A

Acceptance Criteria

• All PRs have been reviewed by at least 1 mentor.
• Code merged into the correct branch "GSoC17"
• When possible, create a release file is provided in the repo.

Definition of Done

• Week 4's code is able to be downloaded from the GSoC17 Branch in the project's repo.

Estimation

• 0.5 Hours

I think it a user , starts a new user ,it should start with a clean slate, not remembering where the previous user left off.

Description

As a player, I want to complete the "Store" scenario,
so that I can earn karma points and buy new things!

Mocks

Borrow the Phone

Acceptance Criteria

User interacts with an NPC.
Once conversation is finished, user is notified with the # of karma points earned.

Definition of Done

Passes all regression tests.
Passes testing per acceptance criteria items.
Approved by UI team.
Able to show feature in demo.

Estimation
TBD

Description

As an User,
I want to be able to reverse an accessory purchase before I save the avatar,
so that I can change my mind if I don't like the accessory look on the avatar.

Mocks
N/A

Acceptance Criteria

User clicks on an accessor to purchase it and karma points are deducted.
User can reverse that purchase before the avatar is saved and the karma points are 'refunded'.

Definition of Done

Passes all regression tests.
Passes testing per acceptance criteria items.
Approved by UI team.
Able to show feature in demo.

Estimation
tbd

Description

As an Admin,
I want to download the current code,
so that I can perform user tests and check on the end result.

Mocks

N/A

Acceptance Criteria

• All PRs have been reviewed by at least 1 mentor.
• Code merged into the correct branch "GSoC17"
• When possible, create a release file is provided in the repo.

Definition of Done

• Week 3's code is able to be downloaded from the GSoC17 Branch in the project's repo.

Estimation

• 0.5 Hours

The home icon on the map is cut off on smaller screen sizes. To fix, have the map and icon images separately and put icon as image for a button (which is constrained to upper right corner).

DevChange made in the Android App:

Currently, after clicking continue in the change room, the user is redirected to the conversation activity. Instead, change it to redirect to the map activity.

Description

As a player,
I want to complete the "Library" scenario,
so that I can earn karma points and buy new things!

Mocks

Puberty Research

Acceptance Criteria

User interacts with an NPC.
Once conversation is finished, user is notified with the # of karma points earned.

Definition of Done

Passes all regression tests.
Passes testing per acceptance criteria items.
Approved by UI team.
Able to show feature in demo.

Estimation
TBD

In the dressing room scene, there are two health bars. The wooden one does not appear in the Android version.

While the iPod scenario currently has a brief summary of the outcome, there should be a page that goes over the lessons taught in the scenario. For the iPod scenes, this could be talking about how to communicate assertively and use "I" statements. For the unprotected level, this could cover the importance of communication between partners and positivity towards safe sex and that there are high risks from unprotected sex.

the clothes have been changed in the android version of the app so the shoes are not translucent anymore. To keep the Android and iOS version the same they should probably be replaced here too.
Can I make a PR for this?

Android PR: https://github.com/systers/powerup-android/pull/301/files

Currently, the question sets and scenes are rather hard-coded. There are many classes with almost the same code. (especially the classes below)

The multiple "Choices" UIControlViews should be rewritten in one.

Currently, every controller open the database and then query and parse the results in the controller itself which should be done via a single class or a singleton class to be apt as data won't change.

I am a GSOC'17 Student. I have implemented Autolayout as well and want to submit PR regarding the same.

Description

As a player,
I want to complete the "Home" scenario-2,
so that I can earn karma points and buy new things!
This scenario is to be completed after the first five stages.

Mocks

Acceptance Criteria

• Also add a warning dialogue before the scenario since it addresses a sensitive issue.
• User interacts with an NPC.
• Once conversation is finished, user is notified with the # of karma points earned.
• Triggered after all stages (Home, Library, School, Hospital) are done.

Definition of Done

• Passes all regression tests.
• Passes testing per acceptance criteria items.
• Able to show feature in demo.

Estimation

2 Hours