GithubHelp home page GithubHelp logo

Comments (15)

sunjunkie avatar sunjunkie commented on August 17, 2024 1

ok

from powerup-ios.

sunjunkie avatar sunjunkie commented on August 17, 2024 1

Yes you can. It is an important part of submitting a PR. You must check the boxes when you submit a PR:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

See:
https://www.raywenderlich.com/960290-ios-unit-testing-and-ui-testing-tutorial
https://devstreaming-cdn.apple.com/videos/wwdc/2019/413kpguqjv5fqp9/413/413_testing_in_xcode.pdf

from powerup-ios.

sunjunkie avatar sunjunkie commented on August 17, 2024

Approved. @AnubhavSingh16 do you want to work on this?

from powerup-ios.

anubhavpulkit avatar anubhavpulkit commented on August 17, 2024

Yes @sunjunkie

from powerup-ios.

anubhavpulkit avatar anubhavpulkit commented on August 17, 2024

@sunjunkie Only members of this organisation add this test to any repo. I'm not approved to add Travis CI test in PowerUp.

from powerup-ios.

sunjunkie avatar sunjunkie commented on August 17, 2024

OK, I'll follow up on this with @mayburgos.

from powerup-ios.

anubhavpulkit avatar anubhavpulkit commented on August 17, 2024

ok

from powerup-ios.

mayburgos avatar mayburgos commented on August 17, 2024

@AnubhavSingh16 Can you screenshot the error you encountered?

from powerup-ios.

anubhavpulkit avatar anubhavpulkit commented on August 17, 2024

Hi, @mayburgos actually Cl test is not running when I send PR to PowerUp after we change our domain from Systers to AnitaB.org but from last PR #393 it is automatically running fine.

from powerup-ios.

anubhavpulkit avatar anubhavpulkit commented on August 17, 2024

You can see the difference in these screenshots

When PowerUp is under Systers organisation CI test works fine you see example in the bottom cases but after the transition from systers to anitaB.org organisation, CI test is not working you can see an example in top cases.
issue problem CI test

from powerup-ios.

anubhavpulkit avatar anubhavpulkit commented on August 17, 2024

but from last PR it works fine automatically you can see the example on the top case.
Untitled

from powerup-ios.

sunjunkie avatar sunjunkie commented on August 17, 2024

@AnubhavSingh16 Have you tried running the tests on your system?

from powerup-ios.

anubhavpulkit avatar anubhavpulkit commented on August 17, 2024

@sunjunkie I think we can't run CI test on our systems it is integrated with GitHub.

from powerup-ios.

anubhavpulkit avatar anubhavpulkit commented on August 17, 2024

Ok, Thank You @sunjunkie

from powerup-ios.

sunjunkie avatar sunjunkie commented on August 17, 2024

Closed in favor of #399

from powerup-ios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.