ankitt26 / leaderboard

In the leaderboard project, we utilize an API to fetch items and set user data along with their scores.

Hi 👋, I'm Ankit kushwaha

A passoinoate Full Stack Web Developer from India. Thrives in remote collaboration and excels in pair programming projects. Expertise in React.js, Redux, JavaScript, Ruby, Ruby on Rails, PostgreSQL, RESTful APIs, Git, and Github.

• 🔭 I’m currently working on Perk-and-Play-Cafe

• 🌱 I’m currently learning Full Stack Web Development

• 👨‍💻 All of my projects are available at https://ankitt26.github.io/Portfolio-setup/

• 💬 Ask me about React, Redux, Javascript, Ruby, Ruby on Rails, PostgreSQL.

• 📫 How to reach me [email protected]

• ⚡ Fun fact I am addicted to coffee and street food 😊

---

Connect with me:

Languages and Tools:

📈 My GitHub Stats:

leaderboard's Issues

Peer to peer code Review

congratulation @ankitt26, you have done excellent work.
The features work as expected, there are just some little improvements in the
code base, kindly check the list below and implement the changes:

• Since the game creation is done only one time, you don't need to create a whole function that you won't longer use, consider using an HTTP client like Postman or Thunderclient (vs code extension) to make the first request (YAGNI clean code principle)
  

  LeaderBoard/modules/setgame.js

  Line 3 in ce5ccc3

  export default async () => {

• Since your base URL is the same, consider using an exported contact instead of using the long string everywhere (DRY clean code principles)
  

  LeaderBoard/modules/getscore.js

  Line 15 in ce5ccc3

  `https://us-central1-js-capstone-backend.cloudfunctions.net/api/games/${gameid}/scores/`,

• Kindly remove the await keyword since you are using .then to handle the promise (YAGNI principle)
  

  LeaderBoard/modules/getscore.js

  Line 14 in ce5ccc3

  await fetch(