anshulxyz / exch Goto Github PK

Markdown doesn't get rendered on the PyPI website. https://pypi.org/project/exch/

Hi,

It's sometimes tough to guess the currency names, would it be possible to have a flag, for instance -l, to list currencies andtheir country ? it could be loaded from hardcoded json for offline support too.

Nb: I am currently packaging this for nixos.org

• Q. Why am I using isinstance() here:

    output = fixer(base, target, amount)
    if isinstance(output, float):
        output = "{} {} = {} {}".format(amount, base, output, target)

    click.echo(output)

• A. Because when the currency is invalid the operation is returning a string.

except KeyError:
        result = 1.00 if base == target else "KeyError: Invalid curreny"

    return result

• Add newline at the end of the JSON files that are being written. Such as here

• Look for a better way to handle Connection Error Exception.

• Refactor file_handling.py

They're the main arguments, they shouldn't have flags.

handle exceptions such as:

• lost internet connection
• improper input given

Date format should be ISO: 2019-07-01

Add how to install test dependencies and working with tox and pytest.

sounds like something I would use but I would rather install it from pypi
python3 -mpip install -U exch --user didn't work is it available there ?

cheers

use click.Group()

for example look at manage/cli.py#L6

http://click.pocoo.org/5/commands/

If just --curr_to is given or just --curr_from, then whole other currencies should be listed nicely. Suggested by Suyog.

• as it has more Currency standards
• have to parse HTML
• returns a 11kb html file

I shouldn't make an API call every a command is fired. That will be abusing the
free API. Running something locally will always be faster than making online
requests. So I'll save the JSON. And have the --sync option to update the
rates.

Currently the default are set like this:

@click.option('--base', '-b', default='USD', type=str, show_default=True,
              help='Currency you are converting from.')
@click.option('--target', '-t', default='INR', type=str, show_default=True,
              help='Currency you\'re converting to.')

Where defaults are set to USD and INR.

User should be able to change this to his preference.