GithubHelp home page GithubHelp logo

Small nit about kilo HOT 2 OPEN

antirez avatar antirez commented on July 22, 2024 3
Small nit

from kilo.

Comments (2)

practicalswift avatar practicalswift commented on July 22, 2024

@DataAnalysisCosby Your simplification looks better in this case. I'm guessing the reasoning behind this structure it is probably to keep it consistent with the other usages of erow *row = …; in the code base:

$ grep 'erow \*row = (' *.c
    erow *row = (filerow >= E.numrows) ? NULL : &E.row[filerow];
    erow *row = (filerow >= E.numrows) ? NULL : &E.row[filerow];
    erow *row = (filerow >= E.numrows) ? NULL : &E.row[filerow];
    erow *row = (filerow >= E.numrows) ? NULL : &E.row[filerow];
    erow *row = (filerow >= E.numrows) ? NULL : &E.row[filerow];
    erow *row = (filerow >= E.numrows) ? NULL : &E.row[filerow];
    erow *row = (filerow >= E.numrows) ? NULL : &E.row[filerow];

from kilo.

SevenBits avatar SevenBits commented on July 22, 2024

@DataAnalysisCosby @practicalswift I would also agree that this simplification is an improvement. It also makes the purpose of the code much more clear.

from kilo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.