antonjb / sprite Goto Github PK

It'd be nice if the play() and stop() methods passed options consistently.

From the readme...

play([options])

stop([frame] [, animated] [, callback])

So one is allowing an object of options to be passed in, the other is asking for a sequence of parameters.

I'd prefer the object way.

Need to add an option for the simple object declaration that will support vertical sprite sheets.

This doesn't work...

this.rocketSprite.stop(
    0,
    true,
    function() {
        console.log("I didn't make it here :(");
    }
)

This does...

this.rocketSprite.stop(
    1,
    true,
    function() {
        console.log("Made it!");
    }
)

Tiny inconsistency... the play() function takes an 'onComplete' attribute as part of its options object. The stop() function has it as 'callback'.

Need to make stop() adhere to the custom FPS and reverse options that can be passed to play.