GithubHelp home page GithubHelp logo

cosmetic-armor's People

Contributors

apace100 avatar craftish37 avatar merchantpug avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

cosmetic-armor's Issues

Incompatible with DragonLoot Helmet

Minecraft: 1.18.2
Fabric: 0.13.3
Cosmetic Armor Version: 1.3.1
DragonLoot Version: 1.0.10

The helmet of the DragonLoot armor (https://www.curseforge.com/minecraft/mc-mods/dragonloot) does not work as a cosmetic helmet and cannot be full overridden by another cosmetic helmet. I think this is because of the extra layer this helmet has. Is there a way to make it compatible? It would be cool if it would also override the elytra version of the chestplate.

Doesn't work properly

Hi! I really like cosmetic armor but It broked somehow!
It doesn't change the armor view that I wanted and there is a gmod-like render error if I don't have any armors on me :(
image
image

Conflict with Azurelib Armor

I've been testing mods, and I found that armours using Azurelib Armor show as a pink error texture when put in the cosmetic slot. Not sure what could be causing this, however that is the only consistency with the issue.

Doesn't seem to work with Create Fabric items

Create (and thus Create Fabric) adds some armor pieces:

Pre-0.5.1 items:
Copper Diving Helmet (create:copper_diving_helmet)
Copper Backtank (create:copper_backtank)
Copper Diving Boots (create:copper_diving_boots)

0.5.1:
Netherite Diving Helmet (create:netherite_diving_helmet)
Netherite Backtank (create:netherite_backtank)
Netherite Diving Boots (create:netherite_diving_boots)

None of these are hidden by Cosmetic Armor, except when leather armor is placed in the cosmetic slot.

Oddly, also, the Netherite Diving Helmet (crafted with a Copper Diving Helmet and a Netherite Helmet or a Copper Diving Helmet and a Netherite Ingot) looks like a Netherite Helmet when placed in the cosmetic slot.

Game crashes when I open my inventory

I'm using the medievalMC modpack for 1.19.2 fabric. The second i put on a helmet my game crashed, everytime i join the server again i can play fine, until i open my inventory because then it just crashes again.

Crashing with custom Mythic Metals Armor rendering

See Noaaan/MythicMetals#72 for crash reports.

I am not able to re-produce this issue in production, but there is something weird going on with my custom armor rendering (Fabrics ArmorRenderer) and Cosmetic Armor.

Some users are reporting crashes despite me not being able to re-produce them.
I would guess it could happen with the helmets, as your HeadFeatureRendererMixin does not check for custom renderers.

If you could push the code from latest Cosmetic Armor up to GitHub it would help investigating this issue

Mod applies "Slot: Cosmetic X" tag to every armor piece's lore

It should only apply when you're wearing an armor piece (if ever it should apply) and it affects newly obtained never-worn brand new armor and makes the lore and look of all armor uglier. Please make it toggle able, disable it, or make it only apply to items being worn.

image
image

Incompatible with BetterEnd Crystalite Armor

When layering cosmetic armor over the Crystalite armor, the crystalite armor still displays. When the Crystalite armor is the cosmetic layer, it renders incorrectly, almost like it's shifting the textures around? No other armor seems to do this.

Versions:
BetterEnd 1.0.2
Cosmetic Armor 1.18 - 1.2.1

Conflicts with one of these mods (maybe you know which one conflicts??)

i know i have a shit ton of mods here but...

bitsandchisels-2.6.7.jar
293.33 kB
chestcavity-2.15.1.jar
0.99 MB
cloth-config-6.2.57-fabric.jar
1.07 MB
CosmeticArmor-1.18-1.2.0.jar
18.56 kB
diggusmaximus-1.5.4-1.18.jar
208.12 kB
expanded-armor-enchanting-1.0.2.jar
10.21 kB
expanded-trident-enchanting-1.0.3.jar
11.86 kB
fabric-api-0.50.0+1.18.2.jar
1.25 MB
fabric-language-kotlin-1.7.2+kotlin.1.6.20.jar
5.79 MB
FastDecay-1.1.0.jar
18.00 kB
fat-experience-orbs-2.0.0+1.18.1.jar
3.54 kB
lithium-fabric-mc1.18.2-0.7.9.jar
433.30 kB
Pehkui-3.2.1+1.14.4-1.19.jar
334.24 kB
ShowMeWhatYouGot-1.18-1.0.0.jar
25.04 kB
spark-1.8.14-fabric.jar
3.07 MB
starlight-1.0.2+fabric.89b8d9f.jar
124.33 kB
TransparentCosmetics-1.4.0.jar
53.52 kB
trinkets-3.3.0.jar
223.82 kB
worldedit-mod-7.2.10.jar
5.25 MB

Thanks so much you are a really cool person (i just copy/paste this)

If you can tell me which is conflicting that would be appreciated
also if you need me to narrow down the mods i will when i have time
im super busy at the moment
school
i just noticed when i added a couple mods to my server it wouldnt start because of cosmeticarmor
yes i have all the dependencies

Incompatible with a few mods

A few mods just show up with no texture when using them, letsdobeachparty (probably all of the letsdo mods) , wizards, plushables and possibly others in my modpack. Fabric 1.20.1. Is there a way to input them manually in the config?

Crashing persistent post patch

Currently playing on Medieval Minecraft v19.5 and I added the cosmetic armor mod myself because I like to look good, but I had a crash after equipping armor from the Bumblezone mod mid-flight with an elytra (from icarus) and would continue to crash upon opening my inventory until I removed this mod

https://mclo.gs/XzMLkeV

I posted this in spite of similar issues existing since most of them lacked logs

Compatibility with CIT Resewn

Is compatibility with CIT Resewn possible/planned? Currently armors with custom textures via CIT Resewn and a CIT Texturepack are rendered as their vanilla counterpart when in the Cosmetic Armor slots.
An API has been inplemented by the developers of CIT Resewn for external mod compatibily.

[Feature Request]

Hi, thank you for the mod. A life-saver to anyone who wants to roleplay. It can even be used as an extra storage slot.

But will you not make a toggle hide armor for this mod? Just like in the curios slots, it seems to me that it really should have this feature in it. Maybe you could even use the eye in the logo itself as a toggle button. The invisible armor mod provided for this purpose is too much of a hassle just for hiding your armor. Nonetheless, great mod!

Crash with Twilight Forest

CosmeticArmor-1.18.2-1.3.1
twilightforest-fabric-1.18.2-4.1.238

When a player has on Twilight Forest armour, then tries to put any cosmetic armour over top of it, the game crashes. This was reported on Twilight Forest's github first, but they said it is an issue with this mod

How to reproduce:

  1. Put on any twilight forest armour. In this case I was using Fiery Leggings and Boots, and Phantom Chestplate and Helmet.
  2. Use any other armour as a cosmetic. In this case I used Chain Boots (just since they're cheap), but other players have reported it happening with other mods also.

Link from TF's git: https://github.com/TeamTwilight/twilightforest-fabric/issues/74
Crash Log: crash-2022-08-11_18.15.49-client.txt

Botania armor causing crash

When your inventory is open, you are wearing 2 full sets of armor, and one of them is made entirely of botania terrasteel, the game will crash. The crash reason is "error rendering entity in world" I am suspicious this has something to do with the little armor preview, because if i use the /inv command to put it on, i have no issues until i open my inventory.

Can randomly cause invalid playerdata

Whenever using Transparent Cosmetics alongside Cosmetic Armor on a dedicated server, relogging causes the transparent armor to become invisible in its respective slots, clicking the slots causes the armor to reappear...
Also whenever somebody equips transparent armor, you have to relog to see the effects...
And finally, there seems to be a randomly occuring issue where the transparent armor will be set to "air" with a count of 1 inside of the player's playerdata, causing them to be unable to join until said count is set to 0.
I have no clue whether this is Trinkets, Cosmetic armor, or Transparent Cosmetics...

[1.19.2] [Fabric] Crash involving Soulslike Weapons and Immersive Armour

This crash seems to involve 3 mods, but I believe the main cause is this mod. I have on an Arkenplate from Soulslike (0.9.9.3), but when I try to use Cosmetic Armour (1.4.20 to make it appear as a Wither Skeleton Chestplate from Immersive Armour (1.5.0), the following crash occurs:

crash-2023-08-11_20.27.36-client.txt
crash-2023-08-11_20.36.39-client.txt

The crashes seem to be the same in nature. Removing CA then removing the skeleton chestplate from the slot fixes the issue

Conflicts with Doom Fabric

Trinket API v3.0.2
cosmetic armor v1.1.0
Doom Fabric v4.0.6

tested on Euphoric Curiosity 1.5

somehow disable the ability to reload within Doom Fabric. tested extensive with AzureDoom (MCdoom dev) and Livii (EC modpack author) to determine this mod somehow caused the issue. no console log produced when recreating the issue.

Cosmetic Helmet shows on other players screen

Minecraft: 1.20.1
Fabric: 0.14.24
Cosmetic Armor: 1.6.0
Mythic Metals: 0.18.2

If player 1 Is wearing a helmet in the Cosmetic Armour slot, and player 2 goes near them, player 2 can see the helmet on their GUI until player 1 takes it off. Seems to have (so far) only happened with Mythic Metals Helmets.

image

Bewitchment Armor not fully fixed

Minecraft: 1.18.2
Fabric: 0.13.3
Version: 1.3.1

Issue: Crash on client-side
Crashlog: https://pastebin.com/ALfx9rux

Steps to reproduce:
Step 1: Set Besmirchment Helmet, Chestplate, Leggings with Harbinger as armor
Step 2: Put any other Armor to the 4 cosmetic slots (in my case it was a netherite armor)

[Suggestion] Refresh Cosmetics Key

Sometimes, Issues can arise with syncing cosmetic armor. (Usually, upon joining a server I can't see cosmetic armor, and have to relog, or unload then reload the player.) and I feel that a key to refresh player's cosmetics will help with this.

Crashing with Bumblezone bee armor in 1.18.2

I have received this bug report:
TelepathicGrunt/Bumblezone-Quilt#66

The issue the user reports is that when they add Bumblezone’s bee chest plate and then any other armor on while in 3rd person view, they get a crash with 3 mixins that show up in the stacktrace. I do not know exactly what is the cause or why the crash occurs.

Could you please take a look and let me know if there’s anything on my end that is the cause or if this is something that cosmetic armor needs to fix? Thank you

How I register my armor models/textures:
https://github.com/TelepathicGrunt/Bumblezone-Fabric/blob/7ca6d8cce2b0802a6555a4c09e2f09ad0545c215/src/main/java/com/telepathicgrunt/the_bumblezone/items/BeeArmor.java#L37

https://github.com/TelepathicGrunt/Bumblezone-Fabric/blob/7ca6d8cce2b0802a6555a4c09e2f09ad0545c215/src/main/java/com/telepathicgrunt/the_bumblezone/client/BumblezoneClient.java#L88

https://github.com/TelepathicGrunt/Bumblezone-Fabric/blob/latest-released/src/main/java/com/telepathicgrunt/the_bumblezone/client/rendering/BeeArmorModel.java

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.