apollo-protocol / 4d-activity-editor Goto Github PK

Description

The tabs show up as a URL instead of a title

Reproduction URL

https://apollo-protocol.github.io/4d-activity-editor/

Reproduction steps

1. Go to https://apollo-protocol.github.io/4d-activity-editor/
2. See the the tab

Screenshots

No response

Logs

No response

Description

Description
When multiple activities share the same beginning or ending events (and, therefore, share the same timestamp in the data_EntityName (literal)) the exported TTL (using save() in the editor app) can have different event data instances representing the same timestamp.

The root cause is likely an absence of checking for existing events in the model before a new event is created in createTimeValue()

Text file below illustrates the issue (repeated event objects for "Infinity", "-Infinity" and "200" (github doesn't allow TTL file upload so saves as a .TXT):

activity_diagram_showing_duplicate_events.txt

What output did you expect?
I expected the TTL to only have a single event object for each unique event.
What output did you get?
Multiple event objects for a unique event. For large activity diagrams this can be many duplicates and is hard to cons

Reproduction URL

Reproduction steps

- Create more than one activity in the UI and export to TTL, with two activities sharing the same boundary.
- Look for `event` objects in TTL.  There will be duplicate events.
The attached TTL file shows the issue.

Screenshots

![DESCRIPTION](LINK.png)

Logs

No response