apostrophecms / apostrophe-redirects Goto Github PK

Cause: Files served directly by nginx before redirects happen

Possible Solution: This probably won't be solved in this module. I think we need to do one/both of these things:

• Rename trashed files (and then name them back on rescue)
• Provide a way to permanently delete trashed items (apostrophecms/apostrophe#654)

Right now there's no error or warning when you create a redirect with the same "from" path as another one. We should check if one exists and at least throw a warning message, if not deny the save.

Right now the instructions use the apostrophe-pieces default template, "You can select content to display by searching for the titles of individual Redirects, or tags." We should override that for this module to better cover its purpose.

The problem to solve

There's no good way to take additional actions, such as tracking redirect use, before a redirect executes

Proposed solution

We emit a Promise event after a matching redirect is found and include both the original URL and its destination.

Alternatives

We could break up the middleware into methods more so they could be edited with the super pattern.

Additional context

This came up from a question in Discord: https://discord.com/channels/517772094482677790/517782236800745495/837372820182401024

I don't know whether this is intentional or not, but we discovered that redirects aren't applied when URL's are requested with a query string. This caused issues for a client of ours when visitors were clicking a link on Facebook and Facebook automatically appended ?fbclid=foobar to the URL.

If there was a way to somehow specify whether query strings should be disregarded or not, that could be very useful!

We may want to configure a way for a user to redirect to a joined piece in some sort of sustainable way that doesn't involve a developer configuring this.

Right now you only have the option to join to a page or hard code a new url.

This is new, i was using a database on mongolab.com and now switched to a local install on the server and made sure it's 2.6.

When i create a redirect the browser alerts: An error occurred. Please try again.
and the app throws this: [Error: key $or must not start with '$']