appearhere / bloom Goto Github PK

First off awesome work, really happy to see AH starting to do some open source!

Just noticed that by default your including your Mapbox public key in the util class. It would be great if this was configurable!

– Chris

The dismissable panel component displays incorrectly with the button on a new line.

Also the documentation has the prop onClick which should be onClose

The following checklist the changes we would like to make to bloom before releasing v1.0.0

• Add .npmignore file #398
• Create a build e.g. UMD
• Add missing components to styleguide

The style guide specimens always show scrollbars on windows even if its not necessary.

Reference: https://docs.codeclimate.com/docs/travis-ci-test-coverage

Will require changes to .travis yml. Our reporter id is:

634c07dccaa4c5d2bf141ca657888c37caadebe0e8bc8b1266f0cb208fc3ebda

We should exclude unnecessary files from the published NPM bundle.

Initial thoughts would be to exclude:

• .storybook
• scripts
• server
• styleguide
• travis
• *.test.js
• *.story.js

As well as all the things in the Git ignore.

Reference: https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package

Thanks to @rdjpalmer for the heads up on this one

Hey there!

I followed the following steps using yarn 1.15.2 starting in the main repo directory:

yarn install
yarn run build
cd styleguide/
yarn run start

I get the following error:

Failed to compile.

./src/components/SiteHeader/SiteHeader.js
Module build failed: Error: Cannot find module 'eslint-visitor-keys'

Every time I run yarn run start in that directory, I get a different error:

Failed to compile.

./src/screens/Design/Iconography.js
Module build failed: Error: ENOENT: no such file or directory, lstat '/mnt/c/Users/Kevin/Documents/Repositories/bloom/node_modules/axobject-query/lib/etc/objects/BannerRole.js'
Referenced from:

Strangely, after trying 5-6 times, it successfully ran.