Comments (3)
nextOutboundStreamID
is definitely thread-safe, as we guard it by an eventLoop.execute
which forces a swap onto the event loop thread.
The issue here is actually long-standing:swift-nio-http2
allocates stream IDs before it has actually created the stream. It does this for a number of reasons, but it is fundamentally brittle. The result is that if you are calling createStreamChannel
repeatedly and quickly you need to ensure that you actually write data on those channels in the order that you created them, or you'll see this error, where the stream channel created second sends its data first.
There are a bunch of things we can do to fix this, but all of them are quite substantial API changes. The ultimate behaviour has to be to create a new HTTP stream channel that does not expect its users to know the stream ID (that is, where the data being passed in the pipeline is HTTP2Frame.Payload
, not HTTP2Frame
). Then we can lazily allocate the stream ID as and when the channel sends its first payload data.
This is not the kind of thing we'd be able to fix quickly, though, so we should also investigate a quick workaround in grpc.
from swift-nio-http2.
Thanks for the prompt response! will close this and continue discussions in grpc-swift repo.
from swift-nio-http2.
Ok, tracking the underlying issue in #214.
from swift-nio-http2.
Related Issues (20)
- HPACKHeaders.peekPseudoHeader allocates awkward temporary array
- HTTP2ChannelHandler.wroteFrame is never returned to false
- Consider returning [Substring] from HPACKHeaders.subscript(canonicalForm:)
- Provide API for adding pseudo headers to HPACKHeaders
- OutboundFlowControlBuffer probably allocates unnecessarily
- Suport HTTP Protocol Upgrade Mechanism HOT 7
- Improve performance of `Substring._trimWhitespace()` HOT 1
- Suppress writes triggered by EOF reads
- Remote pushes with invalid headers leave a stream dangling
- Push latest versions to CocoaPods? HOT 1
- `NIOHTTP2Handler` should handle `ChannelShouldQuiesceEvent` HOT 1
- Reconsider implementation of Equatable and Hashable for HPACKHeaders HOT 2
- Remove @unchecked Sendable when NIOCore adopts Sendable
- Produce a better error when sending HEADERS on a quiesced connection
- StreamMap slow? HOT 7
- Failed assertion in change from 1.24.1 to 1.25.0 HOT 5
- The new HPACK header test for RemoveAll() fails on Android HOT 2
- Race condition causes header frame to be fired on HTTP2StreamChannel AFTER first data frame(s) HOT 3
- Content-Length in responses on HEAD method produce error HOT 3
- Support close mode when closing HTTP2StreamChannel HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swift-nio-http2.