GithubHelp home page GithubHelp logo

kvad's People

Contributors

esad avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

kvad's Issues

Kvad implementation in getsuperpin still has double free issue during destruction

This is a fascinating quadtree implementation!

I wanted to point out that while this seems to be fixed already in this repository, it seems the current getsuperpin (v1.2) implementation still has this bug.

Function in question:

static void _kvad_node_release(kvad_node* node) {
    if (node->subnodes[0]) {
        // Non-leaf node: first free subnodes..
        for (size_t i=0;i<4;i++) {
            _kvad_node_release(node->subnodes[i]);
            free(node->subnodes[i]);
        }
    } else {
        // Leaf node: free data..
        kvad_data *data = node->data;
        while (data) {
            kvad_data *curr = data;
            data = data->next;
            free(curr);
        }
    }
    //..then free this node
    free(node);
}

The first free(node->subnodes[i]); is causing a malloc: *** error for object 0x10d642d80: pointer being freed was not allocated given the node was already deallocated at the bottom of the recursive function.

I apologize if this is not the right place to point this out!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.