appsfuel / atk4 Goto Github PK

I'd like to sanitize the parameters into the model class not in the controller. It's be better to uniform the interface between model and controller.

Should the Data_Controller be stateless or not?

Actually it seems that this is the desired design, so a controller can act and the model stores the actual state of the data (that could also lead to reuse the same instance of the controller on multiple models).

Need to known it for sure! :)

The model passes the id parameter to the controller to know if you are saving or updating a row. The save method of Controller_Data was wrong.

I think the dirty array should be erase after the saving.
I the dirty fields represent the differents between the model data and the source (like db) after the save, the dirty array should be empty

The model class is already iterable. The method count in model already exists. Why shouldn't model implement this interface?

In the load method of the Model there's a call to load method of the controller. In the tryLoad method of the Model there's a call to tryLaod method of the controller. Why don't uniform this?
I suggest to use only tryLoad controller's method

Remove the following methods:
getBy($model,$field,$cond,$value);
getRows($model);
loadBy($model,$field,$cond,$value);

Those methods should be used to serialize and unserialize a model, but the serialization don't store the type of the controller and the other members (like conditions)

Are we sure to serialize a model?

Actually the load hooks are a mess, some kind of load have an hook othesrs have different hook, others have no hook at all.

Instead of having different hooks on each kind of load (load,loadBy, loadAny) we can use a single kind of hook with the first parameter that specify the kind of load and eventually the other parameters as array exacly like the load method signature.

That can uniformate the "beforeLoad" part.