arablocks / ara-util Goto Github PK

Expected Behavior

I get a web3 instance from the ara-util/web3 submodule.

Actual Behavior

web3 wrapper functions are returned, and any modules needing a web3 instance have to get it from ara-context instead.

re: https://github.com/AraBlocks/ara-util/blob/master/index.js#L78

Expected Behavior

Code should check if identityPath exists. If not, error should come back as Identity does not exist at ${identityPath}.

Actual Behavior

if identityPath does not exist, error comes back as Incorrect password.

Steps to Reproduce the Problem

1. use isCorrectPassword and pass in an identity not locally stored

Specifications

all

ara-util should provide function to return a web3 instance. This should reduce the number of situations where both ara-util and ara-context are required, preventing dependency mismatches

Right now the gasPrice is fixed at whatever value web3.eth.getGasPrice() returns. When the network is burdened, it makes tx very slow. Need an option to override gasPrice value.

Is it possible to return tx hash from contract calls? With that, we can create a link to the pending tx on etherscan, which is pretty common for dapps to do. Happy to take a crack at it myself.

Expected Behavior

validate should receive either an AFS DID or an owner's DID as did, along with the corresponding password

Actual Behavior

validate unnecessarily makes a distinction between owner and did in its signature

Existing Behavior

$ afs create
ara: error: Error: Incorrect Password.

Expected Behavior

$ afs create
ara: error: Please recover this AraID using mnemonic on this machine (or something like that).

Check for existence of file here: https://github.com/AraBlocks/ara-util/blob/master/index.js#L77
and throw error directing user to recover identity using mnemonic

Expected Behavior

validate function should take in opts for keyring, since validate will resolve the ddo, and only fall back to constants if necessary.

Actual Behavior

Currently validate uses constants for keyring options, rather than taking in network name/secret.

Steps to Reproduce the Problem

Specifications

• Version:
• Platform:
• Subsystem:

DIDs returned from getLibraryItem in the Library contract are prefixed with 0x. Might be nice to be able to pass these into the function as well.

Expected Behavior

Able to retrieve keys from keyrings

Actual Behavior

n/a

Steps to Reproduce the Problem

1. n/a

Specifications

• Version: 0.3.3
• Platform: n/a
• Subsystem: n/a

We should include the methods here.

Also, we should add isAddress and soliditySha3 support to the web3 module.

Expected Behavior

Projects can rely on a common toHex function

Actual Behavior

Projects write and maintain their own toHex function

Steps to Reproduce the Problem

n/a

Specifications

• Version: 0.3.3
• Platform: n/a
• Subsystem: n/a

Actual Behavior

normalize conflicts with the ara-identity concept of normalize and should be renamed
https://github.com/AraBlocks/ara-identity/blob/master/did.js#L40

Steps to Reproduce the Problem

Specifications

• Version:
• Platform:
• Subsystem:

Expected Behavior

Able to adjust behavior of ara-util without digging through node_modules to change variables

Actual Behavior

Having to dig through node_modules to change constant files

Steps to Reproduce the Problem

1. Use a project that uses ara-filesystem
2. Have to use pre-chosen constants or dig through your node_modules

Specifications

• Version: 0.3.0
• Platform: n/a
• Subsystem: n/a

and add try catches around requires in code.

Expected Behavior

ara-filesystem depends on ara-util only

Actual Behavior

ara-filesystem depends on ara-util and ara-util depends on ara-filesystem

Steps to Reproduce the Problem

1. view in package.json s

Specifications

• Version: all
• Platform: all
• Subsystem: all

Expected Behavior

validate() should throw if an AFS DID is passed in as owner

Actual Behavior

validate() successfully returns if an AFS DID is passed in as owner with the owner's password

Steps to Reproduce the Problem

1. Pass in AFS DID into validate() as owner