aragon / convert.aragon.org

Convert between your Aragon tokens

Aragon Converter

convert.aragon.org's Issues

More than %10 price slippage

I used your system.
This is my first txid: https://etherscan.io/tx/0x130c8ec67f41323d49bceab332cfb3c3029609e36bbe3f3d15f9ad848c3860657
And this is the second: https://etherscan.io/tx/0x50073986ae271bc6f74854558acde1166a7d04882ead339644e0c6debd300333
So the problem is your system promised to convert my 35k anj for at least 447 ant but it paid me only 393 ant. So there is at least 50 ant lost. Please help me. This is not bonding curve doing. The slippage was at least %10.

Transactions repeatedly failing

Have had about a dozen users in the past couple of weeks complain about transactions failing when converting in both directions. I wrote up some documentation about how to interact directly with the contracts to complete the conversion but this should be the exception rather than a common occurrence.

Sentry: catch internal errors

It appears Sentry only picks up internal app errors (e.g. fatal React errors) right now.

What we should do:

• Add a global error catcher like we have in the client and court dashboard (e.g. https://github.com/aragon/court-dashboard/blob/development/src/GlobalErrorHandler.js)
• Capture exceptions from failing async calls (e.g. the ones sending transactions) because they're not in the global or app contexts (instead scoped to each Promise)

We may also want to catch server-side errors, as https://leerob.io/blog/configuring-sentry-for-nextjs-apps suggests.

Add slippage tolerance setting

Uniswap has a slippage tolerance setting that will cause a swap to fail if the trade results in slippage greater than x% of the price quoted to the user at the time they sign and broadcast the trade transaction. The user will lose the gas from their transaction but they at least won't end up overpaying by an unexpected amount.

Could convert.aragon.org implement something similar to prevent issues such as #41?

Second time more than %10 price slippage

This is my first txid: https://etherscan.io/tx/0x6966627757f39ae47b05e7ab9a80e7ba74358c972cf047cae4e0ff1f0dac34e0
And this is the second one https://etherscan.io/tx/0x476076a1ff88121da99f760661871b07f4d7a6eb374f6b6c57389f0e2ba11248

I took SS for this time. Please help me.

Ensure log decoding is reliable

We use receipt event logs to determine the final converted value, we should ensure the ABI encoder can reliably handle edge case failures #38 (comment)

Now: builds failing due to `COMMIT_SHA`

We should update https://github.com/aragon/bonding.aragon.org/blob/master/next.config.js#L7 to handle the Now environment (see https://github.com/aragon/court-dashboard/blob/development/scripts/build.sh#L20-L21).

Use useWallet()

Converter: converted amount input still has cursor

Being able to click on this number input is pretty weird:

Converter: top input should be updatable when not connected

Even when an account is not connected, the top input should be enabled, with the exchanged amount being updated as the top input gets changed.

Convert app shows tx as "failed" even though Etherscan says "success"

This is what convert.aragon.org shows:

And this is what Etherscan shows:

https://etherscan.io/tx/0x686dddc87afc89266892526d10d4c26bdf8fb9966687eec0300a360ead7d1dde

Now my transaction is stuck in a middle state and I can't do anything via convert.aragon.org to complete the tx.

Small UI issues

Creating this issue to gather all the small visual problems that we notice.

---

• Error screen font sizes, spacing, and line break:

• Connect button visual aspect:

• Converter form responsiveness:

• Tooltip position and size:

• Providers selector aspect:

• Convert button and Menu items should be placed closer to the bottom of the screen (48px spacing)

Converter: disable convert when amount is 0

It currently allows you to send transactions to convert nothing, which while technically possible, is not nice :)

Converter: prompt for account connection

After #9, we should make it more intuitive for you to know that you need to connect an account.

Right now the converter button is disabled, and it's not entirely obvious you can only enable it by connecting your account.

My suggestion would be to enable the button, but open the account module popover if no account is connected.